Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP IR-411: support vnet and subnet discovery when provisioning private storage accounts #951

Closed
wants to merge 5 commits into from

Conversation

flavianmissi
Copy link
Member

@flavianmissi flavianmissi commented Nov 1, 2023

This is based on #930. Only the most recent commit is exclusive to this PR.

* abstract azure private endpoint creation
* allow private endpoint configuration via operator config
* add e2e coverage for private storage account life cycle
TODO: remove 'replaces' after openshift/api PR merges
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 1, 2023

@flavianmissi: This pull request references IR-411 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

This is based on #930. Only the most recent commit is exclusive to this feature.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 1, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2023
Copy link
Contributor

openshift-ci bot commented Nov 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavianmissi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 1, 2023

@flavianmissi: This pull request references IR-411 which is a valid jira issue.

In response to this:

This is based on #930. Only the most recent commit is exclusive to this PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@flavianmissi
Copy link
Member Author

/test e2e-azure-operator

Copy link
Contributor

openshift-ci bot commented Nov 8, 2023

@flavianmissi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@flavianmissi
Copy link
Member Author

to minimize the number of PRs we need to merge (and tests we need to wait to pass), I'll merge this one with #930 as a separated commit.
/close

@openshift-ci openshift-ci bot closed this Nov 10, 2023
Copy link
Contributor

openshift-ci bot commented Nov 10, 2023

@flavianmissi: Closed this PR.

In response to this:

to minimize the number of PRs we need to merge (and tests we need to wait to pass), I'll merge this one with #930 as a separated commit.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants