Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCO-248: Revert "Merge pull request #965 from jstuever/TRT-1368" #967

Merged
merged 1 commit into from Dec 8, 2023
Merged

CCO-248: Revert "Merge pull request #965 from jstuever/TRT-1368" #967

merged 1 commit into from Dec 8, 2023

Conversation

flavianmissi
Copy link
Member

This reverts commit ab48b08, reversing changes made to 0c6fdc3.

@flavianmissi
Revert "Merge pull request openshift#965 from jstuever/TRT-1368"
75b3b80 
This reverts commit ab48b08, reversing
changes made to 0c6fdc3.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 30, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 30, 2023 •
edited by openshift-ci bot

@flavianmissi: This pull request references CCO-248 which is a valid jira issue.

In response to this:

This reverts commit ab48b08, reversing changes made to 0c6fdc3.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@flavianmissi
Copy link
Member Author

we need to wait until we get a green light from the CCO team to merge this
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2023
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2023
@flavianmissi
Copy link
Member Author

this isn't user-facing.
/label docs-approved
/label px-approved
QE tested the original PR, so I'll go ahead and give the okay to prioritise merging. CC @wewang58
/labbel qe-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Dec 7, 2023
@flavianmissi
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2023
@dmage
Copy link
Member

dmage commented Dec 7, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, flavianmissi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jstuever
Copy link
Contributor

jstuever commented Dec 7, 2023

/test e2e-gcp-ovn

@wewang58
Copy link

wewang58 commented Dec 8, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Dec 8, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 8, 2023 •
edited by openshift-ci bot

@flavianmissi: This pull request references CCO-248 which is a valid jira issue.

In response to this:

This reverts commit ab48b08, reversing changes made to 0c6fdc3.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 596c819 and 2 for PR HEAD 75b3b80 in total

@flavianmissi
Copy link
Member Author

/test e2e-aws-operator

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 8, 2023

@flavianmissi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 59f66cd into openshift:master Dec 8, 2023
11 checks passed
@flavianmissi flavianmissi deleted the CCO-248 branch December 8, 2023 11:02
@flavianmissi
Copy link
Member Author

/cherry-pick release-4.15

@openshift-cherrypick-robot
Copy link

@flavianmissi: new pull request created: #972

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 8, 2023
Merged
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-image-registry-operator-container-v4.16.0-202312081851.p0.g59f66cd.assembly.stream for distgit ose-cluster-image-registry-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@dmage dmage Awaiting requested review from dmage

Assignees

@dmage dmage

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@flavianmissi @openshift-ci-robot @dmage @jstuever @wewang58 @openshift-cherrypick-robot @openshift-bot