OCPBUGS-29559: Apply hypershift cluster-profile for ibm-cloud-managed

[openshift-art-build-bot]

Since HyperShift / Hosted Control Plane have adopted include.release.openshift.io/ibm-cloud-managed, to tailor the resources of clusters running in the ROKS IBM environment, the include.release.openshift.io/hypershift addition will allow Hypershift to express different profile choices than ROKS

[openshift-ci-robot]

@openshift-art-build-bot: This pull request references Jira Issue OCPBUGS-29558, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Since HyperShift / Hosted Control Plane have adopted include.release.openshift.io/ibm-cloud-managed, to tailor the resources of clusters running in the ROKS IBM environment, the include.release.openshift.io/hypershift addition will allow Hypershift to express different profile choices than ROKS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ashwindasr]

If other files need to be updated to support this change, please let me know.

[openshift-ci-robot]

@openshift-art-build-bot: This pull request references Jira Issue OCPBUGS-29559, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @xiuwang

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Since HyperShift / Hosted Control Plane have adopted include.release.openshift.io/ibm-cloud-managed, to tailor the resources of clusters running in the ROKS IBM environment, the include.release.openshift.io/hypershift addition will allow Hypershift to express different profile choices than ROKS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[flavianmissi]

hi @ashwindasr, you are correct - someone needs to run make update to also update a generated manifest we have under manifests.

EDIT: you might alternatively want to add the hypershift annotation to manifests/07-operator.yaml - it's currently missing and that's why the verify job is failing.

[ashwindasr]

@flavianmissi Thanks for pointing me to manifests/07-operator.yaml. But I see that there is no include.release.openshift.io/ibm-cloud-managed: "true" defined there. So can we add include.release.openshift.io/hypershift: "true" even though the former is missing in that file? Or does that config flow from a different file?

[flavianmissi]

Oof that's a great question @ashwindasr - I have no idea, these annotations are contributed to us by folks outside the team and I don't remember what they do. Maybe we need to ask IBM and hypershift folks?

[ashwindasr]

@flavianmissi https://issues.redhat.com/browse/ART-8431 outlines the details as to why we are adding this annotation.

I can try make update to see if the verify job passes.

[ashwindasr]

Hmm looks like make update is just removing the hypershift line.

[flavianmissi]

yes, it does that because it's not present in the manifests/07-operator.yaml file.

[wewang58]

/jira refresh

[openshift-ci-robot]

@wewang58: This pull request references Jira Issue OCPBUGS-29559, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wewang58

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[wewang58]

/label qe-approved

[openshift-ci]

@openshift-art-build-bot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[flavianmissi]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavianmissi, openshift-art-build-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [flavianmissi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@openshift-art-build-bot: Jira Issue OCPBUGS-29559: All pull requests linked via external trackers have merged:

• openshift/cluster-image-registry-operator#999

Jira Issue OCPBUGS-29559 has been moved to the MODIFIED state.

In response to this:

Since HyperShift / Hosted Control Plane have adopted include.release.openshift.io/ibm-cloud-managed, to tailor the resources of clusters running in the ROKS IBM environment, the include.release.openshift.io/hypershift addition will allow Hypershift to express different profile choices than ROKS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-image-registry-operator-container-v4.17.0-202404220616.p0.gca769eb.assembly.stream.el9 for distgit ose-cluster-image-registry-operator.
All builds following this will include this PR.

[openshift-merge-robot]

Fix included in accepted release 4.16.0-0.nightly-2024-04-23-032717