OCPBUGS-23742: Bump controller-runtime to v0.16.3 #1001
Conversation
Remove the SourceConfigMapNamespace const in favor of the more descriptively named GlobalUserSpecifiedConfigNamespace const, which has the same value. Follow-up to commit 27c838c. * pkg/operator/controller/names.go (SourceConfigMapNamespace): Delete const. * pkg/operator/operator.go (New): Delete SourceConfigMapNamespace from the manager options, which already includes GlobalUserSpecifiedConfigNamespace.
Bump the vendored sigs.k8s.io/controller-runtime package to v0.16.3, the
latest release, which uses the k8s.io/* v0.28.3 packages.
go get sigs.k8s.io/controller-runtime@v0.16.3
go mod tidy
go mod vendor
This commit fixes OCPBUGS-23742.
https://issues.redhat.com/browse/OCPBUGS-23742
* go.mod: Bump.
* go.sum: Regenerate.
* pkg/operator/operator.go (New): Update to use the new DefaultNamespaces
field instead of Namespaces, which has been removed from the manager
options.
* pkg/operator/controller/dns/controller_test.go (Test_customCABundle):
Update to use NewClientBuilder instead of NewFakeClientWithScheme, which
has been removed from controller-runtime.
* vendor/*: Regenerate.
openshift-ci-robot
added
jira/severity-important
|
@Miciah: This pull request references Jira Issue OCPBUGS-23742, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@Miciah: This pull request references Jira Issue OCPBUGS-23742, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
e2e-gcp-operator failed because |
|
@Miciah: Overrode contexts on behalf of Miciah: ci/prow/e2e-gcp-operator In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign |
|
Straightforward change. I reviewed the breaking changes and nothing particular pops out at me. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gcs278 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@Miciah looks like your override was ignored or overridden |
|
/override ci/prow/e2e-gcp-operator |
1 similar comment
|
/override ci/prow/e2e-gcp-operator |
|
@Miciah: Overrode contexts on behalf of Miciah: ci/prow/e2e-gcp-operator In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@Miciah: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@Miciah: Jira Issue OCPBUGS-23742: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-23742 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-ingress-operator-container-v4.15.0-202312020449.p0.gd49eeec.assembly.stream for distgit ose-cluster-ingress-operator. |
|
Fix included in accepted release 4.15.0-0.nightly-2023-12-02-123536 |
Remove
SourceConfigMapNamespaceconstRemove the
SourceConfigMapNamespaceconst in favor of the more descriptively namedGlobalUserSpecifiedConfigNamespaceconst, which has the same value.Follow-up to #588.
pkg/operator/controller/names.go(SourceConfigMapNamespace): Delete const.pkg/operator/operator.go(New): DeleteSourceConfigMapNamespacefrom the manager options, which already includesGlobalUserSpecifiedConfigNamespace.Bump controller-runtime to v0.16.3
Bump the vendored sigs.k8s.io/controller-runtime package to v0.16.3, the latest release, which uses the k8s.io/* v0.28.3 packages.
go.mod: Bump.go.sum: Regenerate.pkg/operator/operator.go(New): Update to use the newDefaultNamespacesfield instead ofNamespaces, which has been removed from the manager options.pkg/operator/controller/dns/controller_test.go(Test_customCABundle): Update to useNewClientBuilderinstead ofNewFakeClientWithScheme, which has been removed from controller-runtime.vendor/*: Regenerate.