OCPBUGS-24531: Update CI and feature for LB scope change

[candita]

NOTE: this is only required if the scope change regression isn't fixed. We do anticipate the resolution of https://issues.redhat.com/browse/OCPBUGS-24044

Update CI and feature surrounding LB scope change

pkg/operator/controller/ingress/load_balancer_service.go
- Remove Azure and GCP as platforms with mutable scope. There are no more platforms with mutable scope.
- Change function loadBalancerServiceIsProgressing to write an error message about the requirement to manually
delete the service after LB scope changed. This marks the LB service as Progressing and subsequently, the
Ingress Operator moves to Progressing until the service is re-created manually.

pkg/operator/controller/ingress/status_test.go
- Change unit test for computeLoadBalancerProgressingStatus to reflect the change in loadBalancerServiceIsProgressing.

test/e2e/operator_test.go
- Change TestScopeChange to perform a check for Progressing all platforms, not just Alibaba, AWS, IBMCloud, and PowerVSP
- Remove the check for platforms that used to update the service themselves (Azure, GCP)

test/e2e/unmanaged_dns_test.go
- In TestUnmanagedDNSToManagedDNSInternalIngressController, delete the service on all platforms, not just Alibaba, AWS, IBMCloud, and PowerVSP.
- - In TestManagedDNSToUnmanagedDNSIngressController, add a timed poll for updates to the wildcard DNS record.

[openshift-ci-robot]

@candita: This pull request references Jira Issue OCPBUGS-24531, which is invalid:

• expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Update CI and feature surrounding LB scope change

pkg/operator/controller/ingress/load_balancer_service.go

• Remove Azure and GCP as platforms with mutable scope. There are no more platforms with mutable scope.
• Change function loadBalancerServiceIsProgressing to write an error message about the requirement to manually
  delete the service after LB scope changed. This marks the LB service as Progressing and subsequently, the
  Ingress Operator moves to Progressing until the service is re-created manually.

pkg/operator/controller/ingress/status_test.go

• Change unit test for computeLoadBalancerProgressingStatus to reflect the change in loadBalancerServiceIsProgressing.

test/e2e/operator_test.go

• Change TestScopeChange to perform a check for Progressing all platforms, not just Alibaba, AWS, IBMCloud, and PowerVSP
• Remove the check for platforms that used to update the service themselves (Azure, GCP)

test/e2e/unmanaged_dns_test.go

• In TestUnmanagedDNSToManagedDNSInternalIngressController, delete the service on all platforms, not just Alibaba, AWS, IBMCloud, and PowerVSP.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from candita. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[candita]

Failure in e2e-aws-ovn-upgrade not due to PR changes, seems related to logging.

Suite run returned error: failed due to a MonitorTest failure
error running options: failed due to a MonitorTest failureerror: failed due to a MonitorTest failure

/test e2e-aws-ovn-upgrade

[candita]

New failure for azure in a different test, TestManagedDNSToUnmanagedDNSIngressController. Checking if permanent, looking into why we would expect status=Unknown in this case.

NAME TestAll/parallel/TestManagedDNSToUnmanagedDNSIngressController
...
unmanaged_dns_test.go:177: DNSRecord zone expected to have status=Unknown but got status=True

/test e2e-azure-operator

[candita]

/jira refresh

[openshift-ci-robot]

@candita: This pull request references Jira Issue OCPBUGS-24531, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@candita: This pull request references Jira Issue OCPBUGS-24531, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

In response to this:

Update CI and feature surrounding LB scope change

pkg/operator/controller/ingress/load_balancer_service.go

• Remove Azure and GCP as platforms with mutable scope. There are no more platforms with mutable scope.
• Change function loadBalancerServiceIsProgressing to write an error message about the requirement to manually
  delete the service after LB scope changed. This marks the LB service as Progressing and subsequently, the
  Ingress Operator moves to Progressing until the service is re-created manually.

pkg/operator/controller/ingress/status_test.go

• Change unit test for computeLoadBalancerProgressingStatus to reflect the change in loadBalancerServiceIsProgressing.

test/e2e/operator_test.go

• Change TestScopeChange to perform a check for Progressing all platforms, not just Alibaba, AWS, IBMCloud, and PowerVSP
• Remove the check for platforms that used to update the service themselves (Azure, GCP)

test/e2e/unmanaged_dns_test.go

• In TestUnmanagedDNSToManagedDNSInternalIngressController, delete the service on all platforms, not just Alibaba, AWS, IBMCloud, and PowerVSP.
• • In TestManagedDNSToUnmanagedDNSIngressController, add a timed poll for updates to the wildcard DNS record.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[candita]

Unrelated error message in e2e-aws-ovn:

Pod e2e-test-oc-templates-bzxcc template-type-precision 1380b640-fd34-481f-b98b-4b643aa1b2a9 v1 205438 spec.containers{test}} Failed
Error: container create failed: time="2023-12-08T20:41:29Z" level=error msg="runc create failed: annotation org.systemd.property.TimeoutStopUSec=uint64 9223372036854775807000000 value parse error: strconv.ParseUint: parsing \"9223372036854775807000000\": value out of range"\n

/test e2e-aws-ovn

[candita]

Unrelated errors in e2e-azure-ovn:

Unsupported cluster type 'azure4' to collect machine IDs
Copying required artifacts to shared dir
error: failed to create/update secret: failed to update secret: Put "https://172.30.0.1:443/api/v1/namespaces/ci-op-7c4yt182/secrets/e2e-azure-ovn": dial tcp 172.30.0.1:443: i/o timeout
�[36mINFO�[0m[2023-12-08T20:27:18Z] Step e2e-azure-ovn-ipi-install-install failed after 55m12s.

/test e2e-azure-ovn

[candita]

TestNodePool failure in e2e-hypershift:

FAIL: TestNodePool (2655.79s)
hypershift_framework.go:180: createHostedCluster()
hypershift_framework.go:245: Creating a new cluster. Options: &{ [hypershift.openshift.io/cleanup-cloud-resources=true hypershift.openshift.io/skip-release-image-validation=true] false SingleReplica false true SingleReplica example-52sml example-52sml e2e-clusters-5vfw4 ci.hypershift.devcluster.openshift.com 0 0s /etc/ci-pull-credentials/.dockerconfigjson registry.build02.ci.openshift.org/ci-op-f8sx5whc/release@sha256:19cff00e9e81a66e4879f0e1b30b2b354328fdbd0e46d2b304cf5e06de24efb9 false [172.31.0.0/16] [10.132.0.0/14] false service.ci.hypershift.devcluster.openshift.com amd64 map[] { true} {Ingress 8Gi 2 32 Filesystem [] [] } {/etc/hypershift-pool-aws-credentials/credentials [expirationDate=2023-12-11T21:19+00:00] https://hypershift-ci-oidc.s3.us-east-1.amazonaws.com/e2e-oidc-provider-zwp7w us-east-1 0 64 gp3 PublicAndPrivate [us-east-1a] false false} { } { eastus Standard_D4s_v4 120 [us-east-1a us-east-1b us-east-1c]} { us-south us-south us-south false false s922 0.5 32} false 0s {0xc000ef3950 0} false Replace false 0x6297ba0}

[candita]

/test e2e-hypershift

[openshift-ci]

@candita: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-operator	88208b0	link	true	/test e2e-gcp-operator
ci/prow/e2e-aws-ovn-single-node	88208b0	link	false	/test e2e-aws-ovn-single-node
ci/prow/e2e-azure-operator	88208b0	link	true	/test e2e-azure-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[candita]

For now we will skip the test, because we anticipate the resolution of https://issues.redhat.com/browse/OCPBUGS-24044

[candita]

/hold

[openshift-ci-robot]

@candita: This pull request references Jira Issue OCPBUGS-24531, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

NOTE: this is only required if the scope change regression isn't fixed. We do anticipate the resolution of https://issues.redhat.com/browse/OCPBUGS-24044

Update CI and feature surrounding LB scope change

pkg/operator/controller/ingress/load_balancer_service.go

• Remove Azure and GCP as platforms with mutable scope. There are no more platforms with mutable scope.
• Change function loadBalancerServiceIsProgressing to write an error message about the requirement to manually
  delete the service after LB scope changed. This marks the LB service as Progressing and subsequently, the
  Ingress Operator moves to Progressing until the service is re-created manually.

pkg/operator/controller/ingress/status_test.go

• Change unit test for computeLoadBalancerProgressingStatus to reflect the change in loadBalancerServiceIsProgressing.

test/e2e/operator_test.go

• Change TestScopeChange to perform a check for Progressing all platforms, not just Alibaba, AWS, IBMCloud, and PowerVSP
• Remove the check for platforms that used to update the service themselves (Azure, GCP)

test/e2e/unmanaged_dns_test.go

• In TestUnmanagedDNSToManagedDNSInternalIngressController, delete the service on all platforms, not just Alibaba, AWS, IBMCloud, and PowerVSP.
• • In TestManagedDNSToUnmanagedDNSIngressController, add a timed poll for updates to the wildcard DNS record.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[candita]

No longer needed.
/close

[openshift-ci]

@candita: Closed this PR.

In response to this:

No longer needed.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@candita: This pull request references Jira Issue OCPBUGS-24531. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

NOTE: this is only required if the scope change regression isn't fixed. We do anticipate the resolution of https://issues.redhat.com/browse/OCPBUGS-24044

Update CI and feature surrounding LB scope change

pkg/operator/controller/ingress/load_balancer_service.go

• Remove Azure and GCP as platforms with mutable scope. There are no more platforms with mutable scope.
• Change function loadBalancerServiceIsProgressing to write an error message about the requirement to manually
  delete the service after LB scope changed. This marks the LB service as Progressing and subsequently, the
  Ingress Operator moves to Progressing until the service is re-created manually.

pkg/operator/controller/ingress/status_test.go

• Change unit test for computeLoadBalancerProgressingStatus to reflect the change in loadBalancerServiceIsProgressing.

test/e2e/operator_test.go

• Change TestScopeChange to perform a check for Progressing all platforms, not just Alibaba, AWS, IBMCloud, and PowerVSP
• Remove the check for platforms that used to update the service themselves (Azure, GCP)

test/e2e/unmanaged_dns_test.go

• In TestUnmanagedDNSToManagedDNSInternalIngressController, delete the service on all platforms, not just Alibaba, AWS, IBMCloud, and PowerVSP.
• • In TestManagedDNSToUnmanagedDNSIngressController, add a timed poll for updates to the wildcard DNS record.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.