NE-1490: update to go v1.20

[candita]

Update to go v1.20

[openshift-ci-robot]

@candita: This pull request references NE-1490 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Update to go v1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[candita]

/test verify

[candita]

/jira refresh

[openshift-ci-robot]

@candita: This pull request references NE-1490 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[candita]

Interesting new failure:

=== NAME TestAll/parallel/TestRouteMetricsControllerOnlyRouteSelector
route_metrics_test.go:386: failed to update route: Operation cannot be fulfilled on routes.route.openshift.io "route-rs-foo-label": the object has been modified; please apply your changes to the latest version and try again

/test e2e-gcp-operator

[candita]

/test e2e-aws-ovn-single-node

level=info msg=Cluster operator insights SCAAvailable is False with Forbidden: Failed to pull SCA certs from https://api.openshift.com/api/accounts_mgmt/v1/certificates: OCM API https://api.openshift.com/api/accounts_mgmt/v1/certificates returned HTTP 403: {"code":"ACCT-MGMT-11","href":"/api/accounts_mgmt/v1/errors/11","id":"11","kind":"Error","operation_id":"e1d319f7-3766-4d00-91cc-d601a91bb6ab","reason":"Account with ID 2DUeKzzTD9ngfsQ6YgkzdJn1jA4 denied access to perform create on Certificate with HTTP call POST /api/accounts_mgmt/v1/certificates"}
...
level=error msg=Cluster initialization failed because one or more operators are not functioning properly.
...
level=error msg=failed to initialize the cluster: Cluster operator console is not available

[candita]

openshift cluster install failed with cluster creation

/test e2e-aws-ovn-single-node

[candita]

Timed out after 4 hours:

[36mINFO�[0m[2024-01-04T23:59:11Z] Running step e2e-aws-ovn-single-node-single-node-e2e-test.
{"component":"entrypoint","file":"k8s.io/test-infra/prow/entrypoint/run.go:169","func":"k8s.io/test-infra/prow/entrypoint.Options.ExecuteProcess","level":"error","msg":"Process did not finish before 4h0m0s timeout","severity":"error","time":"2024-01-05T03:01:22Z"}
�[36mINFO�[0m[2024-01-05T03:01:22Z] Received signal. �[36msignal�[0m=interrupt

/test e2e-aws-ovn-single-node

[Miciah]

Thanks!
/approve
/lgtm

I was curious whether/why Go 1.20 was required. In case anyone else is curious:

% ed Makefile
1625
/GO=
GO=GO111MODULE=on GOFLAGS=-mod=vendor go
s/$/1.19
GO=GO111MODULE=on GOFLAGS=-mod=vendor go1.19
wq
1629
% make test verify
go generate ./pkg/manifests
CGO_ENABLED=1 GO111MODULE=on GOFLAGS=-mod=vendor go1.19 test ./...
# sigs.k8s.io/controller-runtime/pkg/cache
vendor/sigs.k8s.io/controller-runtime/pkg/cache/cache.go:412:58: fields.Selector does not implement comparable
vendor/sigs.k8s.io/controller-runtime/pkg/cache/cache.go:442:20: fields.Selector does not implement comparable
note: module requires Go 1.20

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Miciah]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 9fdc557 and 2 for PR HEAD 0b09b4d in total

[openshift-ci]

@candita: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-single-node	0b09b4d	link	false	/test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[candita]

Cluster failures?

Failed === RUN TestCreateClusterCustomConfig/ValidateHostedCluster
util.go:1384: Waiting for guest client to become available
util.go:117: Waiting for hostedcluster kubeconfig to be published. Namespace: e2e-clusters-hvkfx, name: example-mjqql
util.go:138: Found kubeconfig for cluster in 1m5s. Namespace: e2e-clusters-hvkfx, name: example-mjqql
util.go:158: Waiting for a successful connection to the guest apiserver
util.go:175: Successfully connected to the guest apiserver in 1m5s
util.go:192: Waiting for nodes to become ready. Want: 2
util.go:218:
failed to ensure guest nodes became ready, ready: (0/2):
Unexpected error:
<wait.errInterrupted>:
timed out waiting for the condition
{
cause: <*errors.errorString | 0xc0007760f0>{
s: "timed out waiting for the condition",
},
}
occurred
--- FAIL: TestCreateClusterCustomConfig/ValidateHostedCluster (1865.03s)

/test e2e-hypershift

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-ingress-operator-container-v4.16.0-202401110907.p0.g9c62f2b.assembly.stream for distgit ose-cluster-ingress-operator.
All builds following this will include this PR.