Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-30091: TestHostNetworkPortBinding: Delete t.Parallel() #1032

Merged
merged 1 commit into from Feb 29, 2024
Merged

OCPBUGS-30091: TestHostNetworkPortBinding: Delete t.Parallel() #1032

merged 1 commit into from Feb 29, 2024

Conversation

Miciah
Copy link
Contributor

@Miciah Miciah commented Feb 29, 2024

Remove the t.Parallel() call inside TestHostNetworkPortBinding. The test is listed in TestAll as a serial test, but the test itself calls t.Parallel(), which causes it to run in parallel with other serial tests. This likely causes occasional failures of the test in CI.

@Miciah
TestHostNetworkPortBinding: Delete t.Parallel()
032983d 
Remove the t.Parallel() call inside TestHostNetworkPortBinding.  The test
is listed in TestAll as a serial test, but the test itself calls
t.Parallel(), which causes it to run in parallel with other serial tests.
This likely causes occasional failures of the test in CI.

This commit fixes OCPBUGS-30091.

https://issues.redhat.com/browse/OCPBUGS-30091

* test/e2e/operator_test.go (TestHostNetworkPortBinding): Remove
t.Parallel().
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 29, 2024
@openshift-ci-robot
Copy link
Contributor

@Miciah: This pull request references Jira Issue OCPBUGS-30091, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Remove the t.Parallel() call inside TestHostNetworkPortBinding. The test is listed in TestAll as a serial test, but the test itself calls t.Parallel(), which causes it to run in parallel with other serial tests. This likely causes occasional failures of the test in CI.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Miciah
Copy link
Contributor Author

Miciah commented Feb 29, 2024

/refresh jira

@Miciah
Copy link
Contributor Author

Miciah commented Feb 29, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 29, 2024
@openshift-ci-robot
Copy link
Contributor

@Miciah: This pull request references Jira Issue OCPBUGS-30091, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Miciah Miciah mentioned this pull request Feb 29, 2024
Merged
@candita
Copy link
Contributor

candita commented Feb 29, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 29, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: candita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 29, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a96d79f and 2 for PR HEAD 032983d in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 29, 2024

@Miciah: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn 032983d link false /test e2e-gcp-ovn
ci/prow/e2e-azure-ovn 032983d link false /test e2e-azure-ovn
ci/prow/e2e-aws-ovn-single-node 032983d link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 5a89361 into openshift:master Feb 29, 2024
11 of 14 checks passed
@openshift-ci-robot
Copy link
Contributor

@Miciah: Jira Issue OCPBUGS-30091: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30091 has been moved to the MODIFIED state.

In response to this:

Remove the t.Parallel() call inside TestHostNetworkPortBinding. The test is listed in TestAll as a serial test, but the test itself calls t.Parallel(), which causes it to run in parallel with other serial tests. This likely causes occasional failures of the test in CI.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-ingress-operator-container-v4.16.0-202403010139.p0.g5a89361.assembly.stream.el9 for distgit ose-cluster-ingress-operator.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-03-05-105513

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lihongan lihongan Awaiting requested review from lihongan

@alebedev87 alebedev87 Awaiting requested review from alebedev87

@knobunc knobunc Awaiting requested review from knobunc

Assignees

@candita candita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Miciah @openshift-ci-robot @candita @openshift-bot @openshift-merge-robot