Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-30834: Update to go 1.21 #1040

Merged

Conversation

candita
Copy link
Contributor

@candita candita commented Apr 8, 2024

Update go.mod and .ci-operator.yaml to sync with ART 4.16. Generate go.sum.

Replaces #1033

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 8, 2024
@openshift-ci-robot
Copy link
Contributor

@candita: This pull request references Jira Issue OCPBUGS-30834, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ShudiLi

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Update go.mod and .ci-operator.yaml to sync with ART 4.16. Generate go.sum.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Apr 8, 2024
Copy link
Contributor

openshift-ci bot commented Apr 9, 2024

@candita: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn 5c019ea link false /test e2e-gcp-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ShudiLi
Copy link
Member

ShudiLi commented Apr 9, 2024

tested it with 4.16.0-0.ci.test-2024-04-09-015256-ci-ln-3j4zyrb-latest

% oc get clusterversion
NAME VERSION AVAILABLE PROGRESSING SINCE STATUS
version 4.16.0-0.ci.test-2024-04-09-015256-ci-ln-3j4zyrb-latest True False 14m Cluster version is 4.16.0-0.ci.test-2024-04-09-015256-ci-ln-3j4zyrb-latest

% oc -n openshift-ingress-operator rsync ingress-operator-7975bfb6d5-qkczq:/usr/bin/ingress-operator .
receiving file list ... done
ingress-operator

% go version -m ingress-operator
ingress-operator: go1.21.7 (Red Hat 1.21.7-1.el9) X:strictfipsruntime
path github.com/openshift/cluster-ingress-operator/cmd/ingress-operator
mod github.com/openshift/cluster-ingress-operator (devel)
dep cloud.google.com/go/compute/metadata v0.2.3

@ShudiLi
Copy link
Member

ShudiLi commented Apr 9, 2024

/label qe-approved
thanks

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 9, 2024
@rfredette
Copy link
Contributor

Thanks!
/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2024
Copy link
Contributor

openshift-ci bot commented Apr 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfredette

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD bf974a9 and 2 for PR HEAD 5c019ea in total

@candita
Copy link
Contributor Author

candita commented Apr 10, 2024

/retest-required

@candita
Copy link
Contributor Author

candita commented Apr 11, 2024

Hoping this was temporary:

2024-04-10T20:04:00Z ERROR Failed to create cluster {"error": "cannot discover HyperShift API version: Unauthorized"}
github.com/openshift/hypershift/cmd/cluster/aws.NewCreateCommand.func1
/hypershift/cmd/cluster/aws/create.go:71
github.com/spf13/cobra.(*Command).execute
/hypershift/vendor/github.com/spf13/cobra/command.go:983
github.com/spf13/cobra.(*Command).ExecuteC
/hypershift/vendor/github.com/spf13/cobra/command.go:1115
github.com/spf13/cobra.(*Command).Execute
/hypershift/vendor/github.com/spf13/cobra/command.go:1039
github.com/spf13/cobra.(*Command).ExecuteContext
/hypershift/vendor/github.com/spf13/cobra/command.go:1032
main.main
/hypershift/main.go:78
runtime.main
/usr/lib/golang/src/runtime/proc.go:267
Error: cannot discover HyperShift API version: Unauthorized
cannot discover HyperShift API version: Unauthorized

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit 977b7d4 into openshift:master Apr 11, 2024
13 of 14 checks passed
@openshift-ci-robot
Copy link
Contributor

@candita: Jira Issue OCPBUGS-30834: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-30834 has not been moved to the MODIFIED state.

In response to this:

Update go.mod and .ci-operator.yaml to sync with ART 4.16. Generate go.sum.

Replaces #1033

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-ingress-operator-container-v4.16.0-202404120544.p0.g977b7d4.assembly.stream.el9 for distgit ose-cluster-ingress-operator.
All builds following this will include this PR.

@Miciah
Copy link
Contributor

Miciah commented Apr 16, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@Miciah: Jira Issue OCPBUGS-30834: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30834 has been moved to the MODIFIED state.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants