-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set requests on operator and router deployments #115
Set requests on operator and router deployments #115
Conversation
Set resources.requests.cpu=10m on the operator's container, and set resources.requests.cpu=100m and resources.requests.memory=256Mi on the router's container. The setting for the operator is the standard setting for operators that run on masters. The setting for the router is the default in Origin 3.11 (see <https://github.com/openshift/origin/blob/b054a7bf5b11c760e5dd0f870fc852cc9b8b748b/pkg/oc/cli/admin/router/router.go#L907-L912>). This commit resolves NE-142. https://jira.coreos.com/browse/NE-142 * assets/router/deployment.yaml: Set resources.requests.cpu=100m and resources.requests.memory=256Mi on the router container. * manifests/02-deployment.yaml: Set resources.requests.cpu=10m on the operator container. * pkg/manifests/bindata.go: Regenerate.
c9033f8
to
179cf62
Compare
pods.json from the e2e-aws-operator test run has
and
|
/lgtm |
/refresh |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ironcladlou, Miciah, pravisankar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Set
resources.requests.cpu=10m
on the operator's container, and setresources.requests.cpu=100m
andresources.requests.memory=256Mi
on the router's container.The setting for the operator is the standard setting for operators that run on masters. The setting for the router is the default in Origin 3.11.
This commit resolves NE-142.
assets/router/deployment.yaml
: Setresources.requests.cpu=100m
andresources.requests.memory=256Mi
on the router container.manifests/02-deployment.yaml
: Setresources.requests.cpu=10m
on the operator container.pkg/manifests/bindata.go
: Regenerate.