Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add credentials request for AWS. #116

Merged
merged 1 commit into from
Feb 9, 2019
Merged

Add credentials request for AWS. #116

merged 1 commit into from
Feb 9, 2019

Conversation

dgoodwin
Copy link
Contributor

@dgoodwin dgoodwin commented Feb 5, 2019

Relocated from cloud-credentials-operator repo per recent discussions.
Ingress team will have control over your own creds going forward.

@dgoodwin
Add credentials request for AWS.
602d0b0 
Relocated from cloud-credentials-operator repo per recent discussions.
Ingress team will have control over your own creds going forward.
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 5, 2019
@Miciah
Copy link
Contributor

Miciah commented Feb 5, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 5, 2019
@ironcladlou
Copy link
Contributor

/retest

1 similar comment
@ironcladlou
Copy link
Contributor

/retest

pravisankar
pravisankar reviewed Feb 6, 2019
View reviewed changes
Copy link

@pravisankar pravisankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-merge-robot
Copy link
Contributor

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@pravisankar
Copy link

aws_vpc.new_vpc: Error creating VPC: VpcLimitExceeded: The maximum number of VPCs has been reached.

/retest

@openshift-merge-robot
Copy link
Contributor

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@knobunc
Copy link

knobunc commented Feb 6, 2019

/retest

2 similar comments
@ironcladlou
Copy link
Contributor

/retest

@ironcladlou
Copy link
Contributor

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@ironcladlou
Copy link
Contributor

/retest

1 similar comment
@ironcladlou
Copy link
Contributor

/retest

@ironcladlou
Copy link
Contributor

@dgoodwin something's consistently failing here...

@dgoodwin
Copy link
Contributor Author

dgoodwin commented Feb 7, 2019

Yeah I think it's far before we could break anything though if it's a routing table timeout.

@dgoodwin
Copy link
Contributor Author

dgoodwin commented Feb 7, 2019

Does it seem to be only affecting this PR?

@dgoodwin
Copy link
Contributor Author

dgoodwin commented Feb 7, 2019

/test e2e-aws

@Miciah
Copy link
Contributor

Miciah commented Feb 7, 2019

It's not just this PR (I've seen similar errors on other PRs today), but it seems like this PR has not had any successful runs, which is suspicious.

@dgoodwin
Copy link
Contributor Author

dgoodwin commented Feb 7, 2019

Similar one over in installer just now: https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_installer/1157/pull-ci-openshift-installer-master-e2e-aws/3516

@dgoodwin
Copy link
Contributor Author

dgoodwin commented Feb 8, 2019

/test e2e-aws-operator

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@Miciah
Copy link
Contributor

Miciah commented Feb 9, 2019 •
edited

This is becoming a regular story: operator log and clusterversion have cluster id ca8260f8-9006-4b66-9ca3-153507aba33e while install log has cluster id f703edbe-ee95-4130-a38a-b36907c5fbab, which causes the operator to fail with failed to discover hosted zones: couldn't find private hosted zone for cluster id "ca8260f8-9006-4b66-9ca3-153507aba33e". Additionally, the error from the hosted zone lookup prevented the reconciliation loop from deleting the router-ca configmap when TestClusterIngressUpdate sets a custom default certificate, which causes that test to fail as well.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 8547136 into openshift:master Feb 9, 2019
@dgoodwin dgoodwin deleted the cred-request branch February 11, 2019 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pravisankar pravisankar pravisankar left review comments

@Miciah Miciah Awaiting requested review from Miciah

Assignees

@Miciah Miciah

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@dgoodwin @Miciah @ironcladlou @openshift-merge-robot @openshift-bot @pravisankar @knobunc @openshift-ci-robot