Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default clusteringress's replicas to 2 #120

Conversation

Miciah
Copy link
Contributor

@Miciah Miciah commented Feb 12, 2019

Increase default clusteringress's replicas to 2

  • assets/defaults/cluster-ingress.yaml: Change replicas from 1 to 2.
  • pkg/manifests/bindata.go: Regenerate.

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 12, 2019
* assets/defaults/cluster-ingress.yaml: Change replicas from 1 to 2.
* pkg/manifests/bindata.go: Regenerate.
@Miciah Miciah force-pushed the increase-default-clusteringress's-replicas-to-2 branch from 054bbaf to 806d77e Compare February 12, 2019 06:02
@Miciah
Copy link
Contributor Author

Miciah commented Feb 12, 2019

So far so good—tests all passed. Let's do another pass to see whether anything shakes out...

/test e2e-aws
/test e2e-aws-operator

@Miciah
Copy link
Contributor Author

Miciah commented Feb 12, 2019

e2e-aws and e2e-aws-operators have passed twice now. The logs show no unexpected errors or hotlooping. I can see where TestClusterIngressScale would in the past have been scaling from 1 to 2 and then back to 1, now it is scaling from 2 to 3 and then back to 2.

@openshift/sig-network-edge, any concerns with this change?

@ironcladlou
Copy link
Contributor

Thanks!

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ironcladlou, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 0f3a170 into openshift:master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants