Dep updates to support generating Ingress CRD #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XXL
|
/test e2e-aws |
openshift-ci-robot
added
lgtm
|
/test e2e-aws |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
danehans
force-pushed
the
bz_1683766_deps
branch
from
5f9401d
to
7bbf565
Compare
openshift-ci-robot
added
needs-rebase
danehans
force-pushed
the
bz_1683766_deps
branch
from
7bbf565
to
80cc524
Compare
openshift-ci-robot
removed
the
needs-rebase
|
@pravisankar can you take another look at this PR since your lgtm was removed? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danehans, pravisankar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps library-go to
fc4b2d5cbcf0ab855422e340c78fe7a53a38bee3and addsgithub.com/openshift/library-go/cmd/crd-schema-gendep for PR #183