Bug 1747840: dns: add explicit TTL to all wildcard records #295
Conversation
|
@ironcladlou: This pull request references Bugzilla bug 1747840, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
openshift-ci-robot
added
size/M
Before this commit, wildcard DNS resource record TTLs were inconsistent: * AWS alias record TTLs are not user-configurable. * Azure records TTLs were zero (which is essentially undefined and so causes unpredictable client behavior) * GCP record TTLs were 120 seconds. After this commit, all DNS records default to 30 seconds for any provider which supports setting a TTL for the record type (Azure and GCP at this time). This brings some consistency, and most importantly, eliminates the possibility of zero TTLs.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ironcladlou, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ironcladlou: All pull requests linked via external trackers have merged. Bugzilla bug 1747840 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Before this commit, wildcard DNS resource record TTLs were inconsistent:
unpredictable client behavior)
After this commit, all DNS records default to 30 seconds for any provider which
supports setting a TTL for the record type (Azure and GCP at this time). This
brings some consistency, and most importantly, eliminates the possibility of
zero TTLs.