Bug 1756303: dns/aws: Do not include record in error messages #305
Conversation
Do not include the DNSRecord resource in the error message that the AWS DNS provider returns in the case of a zone-lookup failure. The DNS controller incorporates the error message from the DNS provider into the DNSRecord resource's "Failed" status condition message, which caused problems in the case of repeated zone-lookup failures. Before this commit, such a failure would cause the controller to update the status condition message to include the DNSRecord from the previous failure, which would have a status condition message with the DNSRecord from the second previous failure, which would have a status condition message with the DNSRecord from the third previous failure, and so on. As a result, the DNS controller was making many spurious updates with increasingly long status condition messages, to the point that etcd began rejecting updates with "request is too large". * pkg/dns/aws/dns.go (change): Omit the DNSRecord from the error message for zone-lookup failure.
openshift-ci-robot
added
bugzilla/invalid-bug
ironcladlou
changed the title
|
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1756303, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold We're going to let this one wait for a z-stream. |
openshift-ci-robot
added
the
do-not-merge/hold
|
/approve |
|
/lgtm |
openshift-ci-robot
added
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knobunc, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/bugzilla refresh |
|
@ironcladlou: This pull request references Bugzilla bug 1756303, which is valid. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/valid-bug
|
/hold cancel This can now follow the normal z-stream process. |
openshift-ci-robot
removed
the
do-not-merge/hold
jwforres
added
the
cherry-pick-approved
|
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1756303 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #304
/assign ironcladlou