Bug 1801410: Set affinity for "NodePortService" #357
Conversation
Configure the same deployment strategy and affinity policy on the deployment for an IngressController that uses the "NodePortService" endpoint publishing strategy type as we do for an IngressController that uses the "LoadBalancerService" or "Private" strategy type. Follow-up to commit 3d9a5d3. This commit fixes bug 1801410 https://bugzilla.redhat.com/show_bug.cgi?id=1801410 * pkg/operator/controller/ingress/deployment.go (desiredRouterDeployment): Configure deployment strategy and affinity policy the same for "NodePortService" as for "LoadBalancerService" and "Private".
|
@Miciah: This pull request references Bugzilla bug 1801410, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/valid-bug
|
/cherry-pick release-4.4 |
|
@Miciah: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ironcladlou, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@Miciah: All pull requests linked via external trackers have merged. Bugzilla bug 1801410 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@Miciah: new pull request created: #358 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Configure the same deployment strategy and affinity policy on the deployment for an
IngressControllerthat uses the "NodePortService" endpoint publishing strategy type as we do for anIngressControllerthat uses the "LoadBalancerService" or "Private" strategy type.Follow-up to #343.
pkg/operator/controller/ingress/deployment.go(desiredRouterDeployment): Configure deployment strategy and affinity policy the same for "NodePortService" as for "LoadBalancerService" and "Private".