Bug 1770677: upstream the dnsrecord type #360
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
|
@ironcladlou: This pull request references Bugzilla bug 1770677, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
needs-rebase
|
@ironcladlou: This pull request references Bugzilla bug 1770677, which is valid. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
approved
ironcladlou
force-pushed
the
move-dnsrecord-crd
branch
from
c5b9c22
to
bdaff6b
Compare
openshift-ci-robot
added
size/XL
ironcladlou
force-pushed
the
move-dnsrecord-crd
branch
from
bdaff6b
to
15d6f6c
Compare
ironcladlou
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/retest |
ironcladlou
force-pushed
the
move-dnsrecord-crd
branch
from
15d6f6c
to
1e4c64e
Compare
|
/retest |
| @@ -9,8 +9,8 @@ import ( | |||
|
|
|||
| operatorv1 "github.com/openshift/api/operator/v1" | |||
|
|
|||
| iov1 "github.com/openshift/cluster-ingress-operator/pkg/api/v1" | |||
| ingresscontroller "github.com/openshift/cluster-ingress-operator/pkg/operator/controller" | |||
| "github.com/openshift/cluster-ingress-operator/pkg/operator/controller" | |||
There was a problem hiding this comment.
Maybe import as operatorcontroller? We are inconsistent in how we import this package, and operatorcontroller is the least ambiguous of the options in use.
There was a problem hiding this comment.
Agree, but not sure I agree with another round of CI for it...
|
/test e2e-azure-upgrade |
|
/test e2e-upgrade-azure |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ironcladlou, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ironcladlou: All pull requests linked via external trackers have merged. Bugzilla bug 1770677 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Depends on openshift/api#584