Bug 1842742: nodePortServiceChanged: Fix for session affinity #407
Conversation
When comparing services to determine whether an update is required, treat implicit and explicit default values as equal. Before this commit, the update logic would keep trying to revert the default value that the API set for the service's session affinity. This commit fixes bug 1842742. https://bugzilla.redhat.com/show_bug.cgi?id=1842742 * pkg/operator/controller/ingress/nodeport_service.go (nodePortServiceChanged): Use the new cmpServiceAffinity function so that two services are considered equal if the only difference between them is that one does not specify the session affinity and the other service has the default value. (cmpServiceAffinity): New function. * pkg/operator/controller/ingress/nodeport_service_test.go (TestNodePortServiceChanged): Verify that nodePortServiceChanged returns false if the only mutation is that the session affinity has been updated from empty to the default value.
openshift-ci-robot
added
bugzilla/severity-medium
|
@Miciah: This pull request references Bugzilla bug 1842742, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
approved
|
looks good to me. 🚢 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah, sgreene570 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@Miciah: All pull requests linked via external trackers have merged: openshift/cluster-ingress-operator#407. Bugzilla bug 1842742 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
When comparing services to determine whether an update is required, treat implicit and explicit default values as equal.
Before this commit, the update logic would keep trying to revert the default value that the API set for the service's session affinity.
pkg/operator/controller/ingress/nodeport_service.go(nodePortServiceChanged): Use the newcmpServiceAffinityfunction so that two services are considered equal if the only difference between them is that one does not specify the session affinity and the other service has the default value.(
cmpServiceAffinity): New function.pkg/operator/controller/ingress/nodeport_service_test.go(TestNodePortServiceChanged): Verify thatnodePortServiceChangedreturns false if the only mutation is that the session affinity has been updated from empty to the default value.