dns: Improve logging of reconciliation and updates #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve the logging in the DNS controller and DNS provider implementations to improve visibility into the controller's operation and to avoid printing old and possibly misleading status during reconciliation. * pkg/dns/aws/dns.go (change): * pkg/dns/azure/dns.go (Ensure, Delete): Log the dnsrecord's spec but not its status because the controller only updates the status after ensuring or deleting the dnsrecord. Log the zone along with the dnsrecord's spec. * pkg/operator/controller/dns/controller.go (Reconcile): Log when beginning reconciliation. When updating the status, log the updated dnsrecord rather than the old dnsrecord (with the old status), and always log when updating (not only when the update fails). (publishRecordToZones): Log when skipping a zone. Log the dnsrecord's spec but not its status because the controller only updates the status after publishRecordToZones returns.
openshift-ci-robot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danehans, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the logging in the DNS controller and DNS provider implementations to improve visibility into the controller's operation and to avoid printing old and possibly misleading status during reconciliation.
pkg/dns/aws/dns.go(change):pkg/dns/azure/dns.go(Ensure,Delete): Log the dnsrecord's spec but not its status because the controller only updates the status after ensuring or deleting the dnsrecord. Log the zone along with the dnsrecord's spec.pkg/operator/controller/dns/controller.go(Reconcile): Log when beginning reconciliation. When updating the status, log the updated dnsrecord rather than the old dnsrecord (with the old status), and always log when updating (not only when the update fails).(
publishRecordToZones): Log when skipping a zone. Log the dnsrecord's spec but not its status because the controller only updates the status after publishRecordToZones returns.Inspired by trying to diagnose #417 (comment).