Bug 1887934: TestForwardedHeaderPolicy*: Make case-insensitive #474
Conversation
* test/e2e/forwarded_header_policy_test.go (testRouteHeaders): If the polling loop fails, output the client pod's spec and logs as part of the failure message.
openshift-ci-robot
added
the
approved
Ignore case when comparing the expected response and the actual response in the Forwarded header policy E2E tests. openshift/router#194 turns off HAProxy's HTX option when HTTP/2 is not enabled. As a result, HAProxy does not down-case HTTP header names. * test/e2e/forwarded_header_policy_test.go (testRouteHeaders): Ignore case when comparing the expected response and the actual response.
Miciah
changed the title
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah, sgreene570 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Retconning a BZ to facilitate a backport to 4.6. |
openshift-ci-robot
changed the title
|
@Miciah: All pull requests linked via external trackers have merged: Bugzilla bug 1887934 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.6 |
|
@Miciah: new pull request created: #475 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
TestForwardedHeaderPolicy*: Show pod logs if failedtest/e2e/forwarded_header_policy_test.go(testRouteHeaders): If the polling loop fails, output the client pod's spec and logs as part of the failure message.TestForwardedHeaderPolicy*: Make case-insensitiveIgnore case when comparing the expected response and the actual response in the Forwarded header policy E2E tests. openshift/router#194 turns off HAProxy's HTX option when HTTP/2 is not enabled. As a result, HAProxy does not down-case HTTP header names.
test/e2e/forwarded_header_policy_test.go(testRouteHeaders): Ignore case when comparing the expected response and the actual response.