Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NE-425: Add hello openshift to CI #477

Merged
merged 2 commits into from Oct 20, 2020
Merged

NE-425: Add hello openshift to CI #477

merged 2 commits into from Oct 20, 2020

Conversation

sgreene570
Copy link
Contributor

This PR adds hello-openshift (now built via ART) to manifests/image-references. This is necessary for CI to pick up the hello-openshift image and start including it in 4.7 payloads.

This is in support of https://issues.redhat.com/browse/NE-425 and https://issues.redhat.com/browse/NE-199

@sgreene570
manifests: Add hello-openshift image ref
0c67bb0 
Add the hello-openshift to manifests/image-references.
This is necessary for CI to start including hello-openshift
in OCP release images.
@sgreene570
update bindata
183001d
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2020
@sgreene570
Copy link
Contributor Author

This depends on openshift/release#12636

/hold for now

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 15, 2020
@sgreene570
Copy link
Contributor Author

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2020
@sgreene570
Copy link
Contributor Author

Might take a few for CI to promote hello-openshift now that openshift/release#12636 has merged...

/test images

@sgreene570
Copy link
Contributor Author

Images job succeeded!
/retest

@sgreene570 sgreene570 mentioned this pull request Oct 20, 2020
Merged
@sgreene570
Copy link
Contributor Author

could not initialize namespace: could not create role binding for: rolebindings.rbac.authorization.k8s.io is forbidden: User "system:serviceaccount:ci:ci-operator" cannot create resource "rolebindings" in API group "rbac.authorization.k8s.io" in the namespace "ci-op-mcbb4bm0"

Strange.
/test e2e-aws

@Miciah
Copy link
Contributor

Miciah commented Oct 20, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah, sgreene570

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit c824a39 into openshift:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danehans danehans Awaiting requested review from danehans

@frobware frobware Awaiting requested review from frobware

Assignees

@Miciah Miciah

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sgreene570 @Miciah @openshift-ci-robot @openshift-merge-robot