Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add current profile annotations to CVO manifests #478

Merged
merged 1 commit into from Oct 23, 2020

Conversation

guillaumerose
Copy link
Contributor

This is matches openshift/enhancements#414 and doesn't change existing behavior

@sgreene570
Copy link
Contributor

@guillaumerose could you help me understand precisely what adding the include.release.openshift.io/self-managed-high-availability: "true" annotation does to the ingress operator's manifests?

Also, I think you need to run make update and commit the bindata changes so this PR passes the verify job.

@deads2k
Copy link
Contributor

deads2k commented Oct 23, 2020

This matches the name in https://github.com/openshift/enhancements/blob/master/enhancements/update/cluster-profiles.md#proposal .

@sgreene570 The CVO is going to transition from opt-out cluster profiles to opt-in cluster profiles. This means that the @openshift/sig-network-edge team will get to opt-in for all future cluster profiles instead of discovering that your manifests are suddenly part of a new payload.

The first transition requires that the current profile include.release.openshift.io/self-managed-high-availability: "true" get included in every manifest we currently ship. It's essentially, "keep working as it does today" and future annotations for include.release.openshift.io/*** mean that you are going to be supporting a new payload in a potentially new topology.

/lgtm

/assign @sgreene570
for approval ack

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2020
This is matches openshift/enhancements#414 and doesn't change existing behavior
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2020
@sgreene570
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, guillaumerose, sgreene570

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2020
@openshift-merge-robot openshift-merge-robot merged commit 0118e11 into openshift:master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants