Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1906560: Revert "Support changing ingresscontroller load balancer scope" #514

Conversation

Miciah
Copy link
Contributor

@Miciah Miciah commented Dec 15, 2020

This reverts #472.


This is the backup plan if openshift/api#822 / #510 cannot be merged in 4.7.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2020
@Miciah
Copy link
Contributor Author

Miciah commented Dec 17, 2020

e2e-aws-operator won't pass (see #517), but e2e-aws should...
/retest

@Miciah Miciah changed the title Revert "Support changing ingresscontroller load balancer scope" Bug 1906560: Revert "Support changing ingresscontroller load balancer scope" Dec 17, 2020
@Miciah
Copy link
Contributor Author

Miciah commented Dec 17, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@Miciah: This pull request references Bugzilla bug 1906560, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1906560: Revert "Support changing ingresscontroller load balancer scope"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 17, 2020
@openshift-ci-robot
Copy link
Contributor

@Miciah: This pull request references Bugzilla bug 1906560, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knobunc
Copy link

knobunc commented Dec 17, 2020

/override ci/prow/e2e-aws-operator

This failure is expected until we get a cyclic dependency resolved.

@openshift-ci-robot
Copy link
Contributor

@knobunc: Overrode contexts on behalf of knobunc: ci/prow/e2e-aws-operator

In response to this:

/override ci/prow/e2e-aws-operator

This failure is expected until we get a cyclic dependency resolved.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knobunc
Copy link

knobunc commented Dec 17, 2020

LGTM (but waiting for other reviewers)

@sgreene570
Copy link
Contributor

Thanks Ben
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah, sgreene570

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 902be17 into openshift:master Dec 17, 2020
@openshift-ci-robot
Copy link
Contributor

@Miciah: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1906560 has not been moved to the MODIFIED state.

In response to this:

Bug 1906560: Revert "Support changing ingresscontroller load balancer scope"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Miciah
Copy link
Contributor Author

Miciah commented Dec 17, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@Miciah: All pull requests linked via external trackers have merged:

Bugzilla bug 1906560 has been moved to the MODIFIED state.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants