Bug 1916401: DNS: Skip deleting records that were not published. #529
Conversation
pkg/operator/controller/dns/controller.go: When deleting DNS records from the provider, only delete records that have been successfully published by the provider. This resolves BZ#1916401, in which an ingress controller created with a domain that refers to a non-existent zone cannot be deleted. If the provider failed to publish the DNS record, it will also fail to delete it. It is safe to delete a DNSRecord resource in the cluster when the record does not exist in the provider, since no upstream record needs to be deleted first.
openshift-ci-robot
added
the
bugzilla/severity-medium
|
@sgreene570: This pull request references Bugzilla bug 1916401, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
openshift-ci-robot
added
the
approved
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frobware, sgreene570 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
|
|
/refresh |
|
@sgreene570: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@sgreene570: All pull requests linked via external trackers have merged: Bugzilla bug 1916401 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pkg/operator/controller/dns/controller.go:
When deleting DNS records from the provider, only delete records that
have been successfully published by the provider. This resolves
BZ#1916401, in which an ingress controller created with a domain
that refers to a non-existent zone cannot be deleted. If the provider
failed to publish the DNS record, it will also fail to delete it.
It is safe to delete a DNSRecord resource in the cluster when the record
does not exist in the provider, since no upstream record needs to be
deleted first.