New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1917942: canary: Fail on all errors in Reconcile(...)
#540
Bug 1917942: canary: Fail on all errors in Reconcile(...)
#540
Conversation
pkg/opeator/controller/canary/controller.go: This commit forces the canary controller to hard-fail on any errors encountered during the canary controller's reconcile function since none of these errors are safe to continue on. This fix is to avoid nil derefernce panics when the controller fails to ensure a resource.
@sgreene570: This pull request references Bugzilla bug 1917942, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sgreene570: This pull request references Bugzilla bug 1917942, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
@sgreene570: This pull request references Bugzilla bug 1917942, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@sgreene570: This pull request references Bugzilla bug 1917942, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
yup, the service depends on the dameonset, and the route depends on the service. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: candita, sgreene570 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sgreene570: All pull requests linked via external trackers have merged: Bugzilla bug 1917942 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pkg/opeator/controller/canary/controller.go:
This commit forces the canary controller to hard-fail on any errors
encountered during the canary controller's reconcile function since none
of these errors are safe to continue on. This fix is to avoid nil
derefernce panics when the controller fails to ensure a resource.
This is a follow-up PR to #533. I observed these canary controller panics when scrolling through recent CI failures via https://search.ci.openshift.org/?search=ingress-operator_previous.log.gz&maxAge=336h&context=1&type=junit&name=&maxMatches=5&maxBytes=20971520&groupBy=job .