[release-4.7] Bug 1927080: Verify that Serivce resources have idle annotations from corresponding Endpoint resources, should they exist. #546

openshift-cherrypick-robot · 2021-02-10T02:31:27Z

This is an automated cherry-pick of #542

/assign sgreene570

cmd/ingress-operator/start.go Add a new function, `ensureServicesHaveIdledAnnotation(...)` that mirrors over any idling annotations from endpoint resources when the idling annotations are not present on the corresponding service. Call this function during the operator start up logic so that it only runs once (rather than calling this function within the ingress controller's reconcile function). This function logs any errors and does not cause the operator to crash-loop should an error be encountered.

openshift-ci-robot · 2021-02-10T02:31:36Z

@openshift-cherrypick-robot: Bugzilla bug 1925245 has been cloned as Bugzilla bug 1927080. Retitling PR to link against new bug.
/retitle [release-4.7] Bug 1927080: Verify that Serivce resources have idle annotations from corresponding Endpoint resources, should they exist.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-02-10T02:31:53Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1927080, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1925245 is in the state MODIFIED, which is one of the valid states (MODIFIED, VERIFIED)
dependent Bugzilla bug 1925245 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
bug has dependents

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sgreene570 · 2021-02-10T15:33:52Z

/retest

frobware · 2021-02-10T15:34:26Z

/lgtm

openshift-ci-robot · 2021-02-10T15:34:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frobware, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [frobware]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sgreene570 · 2021-02-10T15:53:23Z

/bugzilla refresh

openshift-ci-robot · 2021-02-10T15:53:27Z

@sgreene570: This pull request references Bugzilla bug 1927080, which is invalid:

expected the bug to target the "4.7.0" release, but it targets "4.7.z" instead
expected dependent Bugzilla bug 1925245 to be in one of the following states: MODIFIED, VERIFIED, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-02-10T18:13:15Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-02-11T01:00:14Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-02-11T01:00:17Z

@openshift-bot: This pull request references Bugzilla bug 1927080, which is invalid:

expected the bug to target the "4.7.0" release, but it targets "4.7.z" instead
expected dependent Bugzilla bug 1925245 to be in one of the following states: MODIFIED, VERIFIED, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sgreene570 · 2021-02-11T18:38:16Z

/bugzilla refresh

openshift-ci-robot · 2021-02-11T18:38:19Z

@sgreene570: This pull request references Bugzilla bug 1927080, which is invalid:

expected the bug to target the "4.7.0" release, but it targets "4.7.z" instead
expected dependent Bugzilla bug 1925245 to be in one of the following states: MODIFIED, VERIFIED, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-02-12T01:00:21Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-02-12T01:00:24Z

@openshift-bot: This pull request references Bugzilla bug 1927080, which is invalid:

expected the bug to target the "4.7.0" release, but it targets "4.7.z" instead
expected dependent Bugzilla bug 1925245 to be in one of the following states: MODIFIED, VERIFIED, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-02-13T01:00:16Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-02-13T01:00:19Z

@openshift-bot: This pull request references Bugzilla bug 1927080, which is invalid:

expected the bug to target the "4.7.0" release, but it targets "4.7.z" instead
expected dependent Bugzilla bug 1925245 to be in one of the following states: MODIFIED, VERIFIED, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-02-15T01:01:45Z

@openshift-bot: This pull request references Bugzilla bug 1927080, which is invalid:

expected the bug to target the "4.7.0" release, but it targets "4.7.z" instead
expected dependent Bugzilla bug 1925245 to be in one of the following states: MODIFIED, VERIFIED, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-02-16T01:00:47Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-02-16T01:00:50Z

@openshift-bot: This pull request references Bugzilla bug 1927080, which is invalid:

expected the bug to target the "4.7.0" release, but it targets "4.7.z" instead
expected dependent Bugzilla bug 1925245 to be in one of the following states: MODIFIED, VERIFIED, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-02-17T01:01:15Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-02-17T01:01:19Z

@openshift-bot: This pull request references Bugzilla bug 1927080, which is invalid:

expected the bug to target the "4.7.0" release, but it targets "4.7.z" instead
expected dependent Bugzilla bug 1925245 to be in one of the following states: MODIFIED, VERIFIED, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-02-17T18:50:43Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-02-17T18:50:47Z

@openshift-bot: This pull request references Bugzilla bug 1927080, which is invalid:

expected the bug to target the "4.7.0" release, but it targets "4.7.z" instead
expected dependent Bugzilla bug 1925245 to be in one of the following states: MODIFIED, VERIFIED, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-02-18T01:00:27Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-02-18T01:00:34Z

@openshift-bot: This pull request references Bugzilla bug 1927080, which is invalid:

expected the bug to target the "4.7.0" release, but it targets "4.7.z" instead
expected dependent Bugzilla bug 1925245 to be in one of the following states: MODIFIED, VERIFIED, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-02-19T01:00:37Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-02-19T01:00:42Z

@openshift-bot: This pull request references Bugzilla bug 1927080, which is invalid:

expected the bug to target the "4.7.0" release, but it targets "4.7.z" instead
expected dependent Bugzilla bug 1925245 to be in one of the following states: MODIFIED, VERIFIED, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-02-20T01:01:02Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-02-20T01:01:05Z

@openshift-bot: This pull request references Bugzilla bug 1927080, which is invalid:

expected the bug to target the "4.7.0" release, but it targets "4.7.z" instead
expected dependent Bugzilla bug 1925245 to be in one of the following states: MODIFIED, VERIFIED, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-02-21T01:00:34Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-02-21T01:00:38Z

@openshift-bot: This pull request references Bugzilla bug 1927080, which is invalid:

expected the bug to target the "4.7.0" release, but it targets "4.7.z" instead
expected dependent Bugzilla bug 1925245 to be in one of the following states: MODIFIED, VERIFIED, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-02-22T01:00:34Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-02-22T01:00:37Z

@openshift-bot: This pull request references Bugzilla bug 1927080, which is invalid:

expected the bug to target the "4.7.0" release, but it targets "4.7.z" instead
expected dependent Bugzilla bug 1925245 to be in one of the following states: MODIFIED, VERIFIED, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-02-23T01:00:57Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-02-23T01:01:00Z

@openshift-bot: This pull request references Bugzilla bug 1927080, which is invalid:

expected the bug to target the "4.7.0" release, but it targets "4.7.z" instead
expected dependent Bugzilla bug 1925245 to be in one of the following states: MODIFIED, VERIFIED, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-02-24T01:01:09Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-02-24T01:01:13Z

@openshift-bot: This pull request references Bugzilla bug 1927080, which is invalid:

expected the bug to target the "4.7.0" release, but it targets "4.7.z" instead
expected dependent Bugzilla bug 1925245 to be in one of the following states: MODIFIED, VERIFIED, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-02-25T01:00:26Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-02-25T01:00:34Z

@openshift-bot: This pull request references Bugzilla bug 1927080, which is invalid:

expected dependent Bugzilla bug 1925245 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sgreene570 · 2021-02-25T14:57:26Z

/bugzilla refresh

openshift-ci-robot · 2021-02-25T14:58:39Z

@sgreene570: This pull request references Bugzilla bug 1927080, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.z) matches configured target release for branch (4.7.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1925245 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1925245 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
bug has dependents

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-03-02T23:54:36Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

openshift/cluster-ingress-operator#546

Bugzilla bug 1927080 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sgreene570 added 2 commits February 10, 2021 02:31

vendor: Import openshift unidling API

c02dd6b

openshift-ci-robot assigned sgreene570 Feb 10, 2021

openshift-cherrypick-robot mentioned this pull request Feb 10, 2021

Bug 1925245: Verify that Serivce resources have idle annotations from corresponding Endpoint resources, should they exist. #542

Merged

openshift-ci-robot requested review from knobunc and sgreene570 February 10, 2021 02:31

openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Feb 10, 2021

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 10, 2021

openshift-ci-robot assigned frobware Feb 10, 2021

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 10, 2021

openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Feb 10, 2021

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 25, 2021

mrunalp added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 2, 2021

openshift-merge-robot merged commit 948f17b into openshift:release-4.7 Mar 2, 2021

[release-4.7] Bug 1927080: Verify that Serivce resources have idle annotations from corresponding Endpoint resources, should they exist. #546

[release-4.7] Bug 1927080: Verify that Serivce resources have idle annotations from corresponding Endpoint resources, should they exist. #546

Conversation

openshift-cherrypick-robot commented Feb 10, 2021

openshift-ci-robot commented Feb 10, 2021

openshift-ci-robot commented Feb 10, 2021

sgreene570 commented Feb 10, 2021

frobware commented Feb 10, 2021

openshift-ci-robot commented Feb 10, 2021

sgreene570 commented Feb 10, 2021

openshift-ci-robot commented Feb 10, 2021

openshift-bot commented Feb 10, 2021

openshift-bot commented Feb 11, 2021

openshift-ci-robot commented Feb 11, 2021

sgreene570 commented Feb 11, 2021

openshift-ci-robot commented Feb 11, 2021

openshift-bot commented Feb 12, 2021

openshift-ci-robot commented Feb 12, 2021

openshift-bot commented Feb 13, 2021

openshift-ci-robot commented Feb 13, 2021

openshift-ci-robot commented Feb 15, 2021

openshift-bot commented Feb 16, 2021

openshift-ci-robot commented Feb 16, 2021

openshift-bot commented Feb 17, 2021

openshift-ci-robot commented Feb 17, 2021

openshift-bot commented Feb 17, 2021

openshift-ci-robot commented Feb 17, 2021

openshift-bot commented Feb 18, 2021

openshift-ci-robot commented Feb 18, 2021

openshift-bot commented Feb 19, 2021

openshift-ci-robot commented Feb 19, 2021

openshift-bot commented Feb 20, 2021

openshift-ci-robot commented Feb 20, 2021

openshift-bot commented Feb 21, 2021

openshift-ci-robot commented Feb 21, 2021

openshift-bot commented Feb 22, 2021

openshift-ci-robot commented Feb 22, 2021

openshift-bot commented Feb 23, 2021

openshift-ci-robot commented Feb 23, 2021

openshift-bot commented Feb 24, 2021

openshift-ci-robot commented Feb 24, 2021

openshift-bot commented Feb 25, 2021

openshift-ci-robot commented Feb 25, 2021

sgreene570 commented Feb 25, 2021

openshift-ci-robot commented Feb 25, 2021

openshift-ci-robot commented Mar 2, 2021