ensureRsyslogConfigMap: Remove ingressConfig param #573
Conversation
|
@Miciah: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
@Miciah This change looks good, id be happy to tag it after a rebase |
openshift-ci
bot
removed
the
lifecycle/stale
Stop unnecessarily passing ingressConfig to ensureRsyslogConfigMap and desiredRsyslogConfigMap, which previously used the value but no longer do. Follow-up to commit 1da14ee. * pkg/operator/controller/ingress/controller.go (ensureIngressController): Remove the ingressConfig argument in the call to ensureRsyslogConfigMap. * pkg/operator/controller/ingress/rsyslog_configmap.go (ensureRsyslogConfigMap, desiredRsyslogConfigMap): Remove the ingressConfig parameter.
Miciah
force-pushed
the
ensureRsyslogConfigMap-remove-ingressConfig-parameter
branch
from
701c019
to
30c4c44
Compare
|
Rebased. |
openshift-ci
bot
removed
the
needs-rebase
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frobware, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
Stop unnecessarily passing
ingressConfigtoensureRsyslogConfigMapanddesiredRsyslogConfigMap, which previously used the value but no longer do.Follow-up to #374.
pkg/operator/controller/ingress/controller.go(ensureIngressController): Remove theingressConfigargument in the call toensureRsyslogConfigMap.pkg/operator/controller/ingress/rsyslog_configmap.go(ensureRsyslogConfigMap,desiredRsyslogConfigMap): Remove theingressConfigparameter.