Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.7] Bug 1954097: Annotate services of type LoadBalancer with user tags (AWS only) #606

Merged
merged 2 commits into from Apr 29, 2021
Merged

[release-4.7] Bug 1954097: Annotate services of type LoadBalancer with user tags (AWS only) #606

merged 2 commits into from Apr 29, 2021

Conversation

frobware
Copy link
Contributor

@frobware frobware commented Apr 27, 2021 •
edited

This is a manual backport of #578.

This needs the following 4.7 backports:

And this PR to stand up a cluster and test e2e:

@frobware
Add resource tags to AWS load balancers
57e3bc5 
If the infrastructure object (on AWS) has additional user supplied
resource tags specified then annotate services of type LoadBalancer as
follows:

 "service.beta.kubernetes.io/aws-load-balancer-additional-resource-tags": "Key1=Value1,KeyN=ValueN"

https://issues.redhat.com/browse/NE-563

This is only done at create time, per the enhancement proposal.
Existing services are not tagged. Equally, no reconciliation is done
if the resource keys/values change.
@frobware
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 27, 2021
@openshift-ci-robot
Copy link
Contributor

@frobware: This pull request references Bugzilla bug 1954097, which is invalid:

  • expected dependent Bugzilla bug 1950284 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@frobware: This pull request references Bugzilla bug 1954097, which is invalid:

  • expected dependent Bugzilla bug 1950284 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.7] Bug 1954097: Annotate services of type LoadBalancer with user tags (AWS only)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@frobware
Copy link
Contributor Author

/hold

This is waiting on 4.7 backports of:

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 27, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2021
@openshift-ci-robot
Copy link
Contributor

@frobware: This pull request references Bugzilla bug 1954097, which is invalid:

  • expected dependent Bugzilla bug 1950284 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.7] Bug 1954097: Annotate services of type LoadBalancer with user tags (AWS only)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@frobware
Copy link
Contributor Author

4.7 openshift/api backport - openshift/api#914

@frobware
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@frobware: An error was encountered querying GitHub for users with public email (hongli@redhat.com) for bug 1954097 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: i/o timeout

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@frobware
Copy link
Contributor Author

/refresh
/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@frobware: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-operator 57e3bc5 link /test e2e-aws-operator
ci/prow/e2e-aws 57e3bc5 link /test e2e-aws
ci/prow/e2e-upgrade 57e3bc5 link /test e2e-upgrade
ci/prow/unit 57e3bc5 link /test unit
ci/prow/images 57e3bc5 link /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 28, 2021
@openshift-ci-robot
Copy link
Contributor

@frobware: This pull request references Bugzilla bug 1954097, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1950284 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1950284 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

Requesting review from QA contact:
/cc @lihongan

In response to this:

/refresh
/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 28, 2021
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. and removed bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 28, 2021
@openshift-ci-robot
Copy link
Contributor

@frobware: This pull request references Bugzilla bug 1954097, which is invalid:

  • expected dependent Bugzilla bug 1954152 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is NEW instead
  • expected dependent Bugzilla bug 1954152 to target a release in 4.8.0, but it targets "4.7.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.7] Bug 1954097: Annotate services of type LoadBalancer with user tags (AWS only)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 28, 2021
@frobware
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 28, 2021
@openshift-ci-robot
Copy link
Contributor

@frobware: This pull request references Bugzilla bug 1954097, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1950284 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1950284 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

Requesting review from QA contact:
/cc @lihongan

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@frobware
Copy link
Contributor Author

/hold cancel

openshift/api#914 has merged and we only need that for this to build and pass CI.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2021
@openshift-ci-robot
Copy link
Contributor

@frobware: This pull request references Bugzilla bug 1954097, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1950284 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1950284 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

Requesting review from QA contact:
/cc @lihongan

In response to this:

[release-4.7] Bug 1954097: Annotate services of type LoadBalancer with user tags (AWS only)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@frobware
Copy link
Contributor Author

Not sure if this is a flake ATM:

INFO[2021-04-29T10:21:35Z] operator_test.go:1883: deleted ingresscontroller headercapture
INFO[2021-04-29T10:21:35Z] --- PASS: TestHTTPHeaderCapture (27.45s)
INFO[2021-04-29T10:21:35Z] === RUN TestHTTPCookieCapture
INFO[2021-04-29T10:21:35Z] operator_test.go:1404: failed to get the console route: the server is currently unable to handle the request (get routes.route.openshift.io console)
INFO[2021-04-29T10:21:35Z] operator_test.go:1883: deleted ingresscontroller cookiecapture
INFO[2021-04-29T10:21:35Z] --- FAIL: TestHTTPCookieCapture (50.61s)

/test e2e-aws-operator

@frobware
Copy link
Contributor Author

[sig-api-machinery][Feature:APIServer][Late] kube-apiserver terminates within graceful termination period [Suite:openshift/conformance/parallel] -- failed

/retest

@frobware
Copy link
Contributor Author

Hmm. TestHTTPCookieCapture failed again.

/retest

@sgreene570
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frobware, sgreene570

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [frobware,sgreene570]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@frobware
Copy link
Contributor Author

ClusterVersion: Installing "" for :
error getting cluster operators: Get "https://api.ci-op-l3ilc5fg-3ab10.origin-ci-int-aws.dev.rhcloud.com:6443/apis/config.openshift.io/v1/clusteroperators": dial tcp 34.201.228.26:6443: connect: connection refused

/retest

@bparees bparees added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 29, 2021
@openshift-merge-robot openshift-merge-robot merged commit 1cf3087 into openshift:release-4.7 Apr 29, 2021
@openshift-ci-robot
Copy link
Contributor

@frobware: All pull requests linked via external trackers have merged:

Bugzilla bug 1954097 has been moved to the MODIFIED state.

In response to this:

[release-4.7] Bug 1954097: Annotate services of type LoadBalancer with user tags (AWS only)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@frobware frobware deleted the aws-labelling-4.7-backport-bz1954097 branch September 5, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ironcladlou ironcladlou Awaiting requested review from ironcladlou

@Miciah Miciah Awaiting requested review from Miciah

@lihongan lihongan Awaiting requested review from lihongan

Assignees

@sgreene570 sgreene570

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@frobware @openshift-ci-robot @sgreene570 @bparees @openshift-merge-robot