Add unsupported config override for config manager #628
Conversation
openshift-ci
bot
added
approved
Miciah
force-pushed
the
add-unsupported-config-override-for-config-manager
branch
from
b5601bd
to
74cec30
Compare
|
Rebased. |
openshift-ci
bot
removed
the
needs-rebase
Miciah
changed the title
test/e2e/operator_test.go
Outdated
| t.Fatalf("failed to update ingresscontroller: %v", err) | ||
| } | ||
| if err := waitForDeploymentEnvVar(t, kclient, deployment, 1*time.Minute, "ROUTER_HAPROXY_CONFIG_MANAGER", "true"); err != nil { | ||
| t.Fatalf("expected initial deployment to set ROUTER_HAPROXY_CONFIG_MANAGER=true: %v", err) |
There was a problem hiding this comment.
"expected updated deployment"?
Add an unsupported config override to enable OpenShift router's dynamic config manager for HAProxy. * pkg/operator/controller/ingress/deployment.go (RouterHAProxyConfigManager): New const. (desiredRouterDeployment): Add unsupported config override for ROUTER_HAPROXY_CONFIG_MANAGER. * pkg/operator/controller/ingress/deployment_test.go (TestDesiredRouterDeployment): Verify that desiredRouterDeployment sets ROUTER_HAPROXY_CONFIG_MANAGER as expected. * test/e2e/operator_test.go (TestDynamicConfigManagerUnsupportedConfigOverride): Verify that the operator sets ROUTER_HAPROXY_CONFIG_MANAGER on a router deployment for an IngressController that enables the unsupported config override.
Miciah
force-pushed
the
add-unsupported-config-override-for-config-manager
branch
from
74cec30
to
6a8516a
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frobware, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@Miciah , we're wondering for this feature, other than this being explicitly unsupported, are the any drawbacks as to why we should not consider using this a way to address our issues with connection termination? And when it will be officially supported? Thanks. |
Enabling the override is not currently tested either manually or in any CI jobs that we have/use. I cannot vouch for its current behaviour. |
|
@frobware , thanks for the reply. So do you have plan when this feature will be "supported"? |
|
@showuon the RFE is tracked here: https://issues.redhat.com/browse/RFE-1439. Notably the spike https://issues.redhat.com/browse/NE-870 is still to be done. I don't have any answer for you as to "when'. |
|
Thank you for the comments. I see. Thanks. |
Add an unsupported config override to enable OpenShift router's dynamic config manager for HAProxy.
pkg/operator/controller/ingress/deployment.go(RouterHAProxyConfigManager): New const.(
desiredRouterDeployment): Add unsupported config override forROUTER_HAPROXY_CONFIG_MANAGER.pkg/operator/controller/ingress/deployment_test.go(TestDesiredRouterDeployment): Verify thatdesiredRouterDeploymentsetsROUTER_HAPROXY_CONFIG_MANAGERas expected.test/e2e/operator_test.go(TestDynamicConfigManagerUnsupportedConfigOverride): Verify that the operator setsROUTER_HAPROXY_CONFIG_MANAGERon a router deployment for an IngressController that enables the unsupported config override.