Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1986228: NE-310 E2E test for HSTS #639

Merged
merged 1 commit into from Aug 12, 2021
Merged

Bug 1986228: NE-310 E2E test for HSTS #639

merged 1 commit into from Aug 12, 2021

Conversation

candita
Copy link
Contributor

@candita candita commented Jul 28, 2021 •
edited

Simple e2e test to ensure:

  • updated CRD is available
  • HSTS validation is operational
  • HSTS header is returned from query to annotated route

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 28, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2021 •
edited

@candita: This pull request references Bugzilla bug 1986228, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @lihongan

In response to this:

Bug 1986228: NE-310 E2E test for HSTS - vendor files

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2021
@candita
Copy link
Contributor Author

candita commented Jul 28, 2021 •
edited

Depends on merge of openshift/openshift-apiserver#224
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2021
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 28, 2021
@candita candita force-pushed the BZ-1986228-e2eTests branch 2 times, most recently from 3d655f2 to 66694c5 Compare July 28, 2021 03:25
@candita
Copy link
Contributor Author

candita commented Jul 28, 2021

/test images

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2021 •
edited

@candita: This pull request references Bugzilla bug 1986228, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @lihongan

In response to this:

Bug 1986228: NE-310 E2E test for HSTS - vendor files

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@candita candita force-pushed the BZ-1986228-e2eTests branch 2 times, most recently from c92663c to d0f61d9 Compare July 28, 2021 04:19
@candita candita changed the title Bug 1986228: NE-310 E2E test for HSTS - vendor files Bug 1986228: NE-310 E2E test for HSTS Jul 28, 2021
@candita candita force-pushed the BZ-1986228-e2eTests branch 4 times, most recently from cf7bd01 to c4c3e62 Compare July 28, 2021 21:40
@candita candita changed the title Bug 1986228: NE-310 E2E test for HSTS [WIP] Bug 1986228: NE-310 E2E test for HSTS Jul 28, 2021
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 28, 2021
@candita candita force-pushed the BZ-1986228-e2eTests branch 2 times, most recently from 3fd8c2d to b166fd2 Compare July 30, 2021 02:55
@candita
Copy link
Contributor Author

candita commented Jul 30, 2021 

=== RUN   TestHstsPolicyWorks
    hsts_policy_test.go:66: created a RequiredHSTSPolicy with DomainPatterns: [hsts-policy.ci-ln-rvipfd2-d5d6b.origin-ci-int-aws.dev.rhcloud.com hsts-policy2.ci-ln-rvipfd2-d5d6b.origin-ci-int-aws.dev.rhcloud.com], preload policy: RequirePreload, includeSubDomains policy: RequireIncludeSubDomains, largest age: 99999, smallest age: 1
    hsts_policy_test.go:125: Creating first route at 2021-07-29 22:23:59.475874431 -0400 EDT m=+39.051669860
    hsts_policy_test.go:131: created a route at 2021-07-29 22:23:59.51421413 -0400 EDT m=+39.090009562: openshift-ingress/hsts-policy-echo with annotation map[haproxy.router.openshift.io/hsts_header:max-age=99999;preload;includesubdomains]
    hsts_policy_test.go:135: Creating second route at 2021-07-29 22:23:59.514254393 -0400 EDT m=+39.090049814
    hsts_policy_test.go:141: rejected an invalid route at 2021-07-29 22:23:59.535622434 -0400 EDT m=+39.111417864: openshift-ingress/hsts-policy-echo2 with annotation map[haproxy.router.openshift.io/hsts_header:max-age=99999999]: routes.route.openshift.io "hsts-policy-echo2" is forbidden: is greater than maximum age (99999)
    hsts_policy_test.go:151: deleted ingresscontroller hsts-policy
--- PASS: TestHstsPolicyWorks (37.53s)
PASS

@candita
Copy link
Contributor Author

candita commented Jul 30, 2021

SCC error
/retest

@candita
Copy link
Contributor Author

candita commented Aug 11, 2021 •
edited by openshift-ci bot

...skipping gathering podnetworkconnectivitychecks.controlplane.operator.openshift.io due to error: the server doesn't have a resource type "podnetworkconnectivitychecks", skipping gathering EgressFirewall.k8s.ovn.org due to error: the server doesn't have a resource type "EgressFirewall", skipping gathering EgressIP.k8s.ovn.org due to error: the server doesn't have a resource type "EgressIP", skipping gathering endpoints/host-[etcd-2](https://issues.redhat.com/browse/etcd-2) due to error: endpoints "host-[etcd-2](https://issues.redhat.com/browse/etcd-2)" not found, skipping gathering namespaces/openshift-manila-csi-driver due to error: namespaces "openshift-manila-csi-driver" not found]
/test e2e-upgrade

frobware
frobware reviewed Aug 11, 2021
View reviewed changes
test/e2e/util.go Outdated Show resolved Hide resolved
@candita candita force-pushed the BZ-1986228-e2eTests branch 2 times, most recently from 4362081 to 2c1f968 Compare August 11, 2021 17:06
@candita
Copy link
Contributor Author

candita commented Aug 11, 2021 •
edited

`Aug 11 18:01:20.878 E ns/e2e-test-cluster-client-cert-jxtsg pod/get-bootstrap-creds node/ip-10-0-181-124.ec2.internal container/get-bootstrap-creds container exited with code 137 (Error):
/test e2e-aws

@candita
Copy link
Contributor Author

candita commented Aug 11, 2021

/test e2e-aws

@candita
Copy link
Contributor Author

candita commented Aug 11, 2021 

fail [github.com/openshift/origin/test/extended/authorization/scc.go:73]: 8 pods failed before test on SCC errors
Error creating: pods "cloud-credential-operator-c57746c7b-" is forbidden: unable to validate against any security context constraint: provider "privileged": Forbidden: not usable by user or serviceaccount for ReplicaSet.apps/v1/cloud-credential-operator-c57746c7b -n openshift-cloud-credential-operator happened 12 times

/test e2e-upgrade

frobware
frobware requested changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@frobware frobware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just a few things to tidy up. Thanks for persevering here.

test/e2e/hsts_policy_test.go Outdated Show resolved Hide resolved
test/e2e/hsts_policy_test.go Show resolved Hide resolved
test/e2e/hsts_policy_test.go Outdated Show resolved Hide resolved
test/e2e/hsts_policy_test.go Outdated Show resolved Hide resolved
frobware
frobware reviewed Aug 11, 2021
View reviewed changes
test/e2e/util.go Outdated Show resolved Hide resolved
frobware
frobware reviewed Aug 11, 2021
View reviewed changes
test/e2e/util.go Outdated Show resolved Hide resolved
@frobware
Copy link
Contributor

@candita thanks for persevering with all the changes over the last few days.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 12, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: candita, frobware

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@candita
Copy link
Contributor Author

candita commented Aug 12, 2021 

...Bootstrap failed to complete: timed out waiting for the condition
level=error msg=Failed to wait for bootstrapping to complete. This error usually happens when there is a problem with control plane hosts that prevents the control plane operators from creating the control plane.

/test e2e-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 12, 2021 •
edited

@candita: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-single-node 7438696 link /test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci bot merged commit f6b6e0d into openshift:master Aug 12, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 12, 2021 •
edited

@candita: All pull requests linked via external trackers have merged:

Bugzilla bug 1986228 has been moved to the MODIFIED state.

In response to this:

Bug 1986228: NE-310 E2E test for HSTS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frobware frobware frobware requested changes

@lihongan lihongan Awaiting requested review from lihongan

@rfredette rfredette Awaiting requested review from rfredette

Assignees

@frobware frobware

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@candita @frobware @openshift-bot