Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.9] Bug 2057518: Normalize the AWS internal LB annotation value #706

Merged
merged 1 commit into from Mar 16, 2022
Merged

[release-4.9] Bug 2057518: Normalize the AWS internal LB annotation value #706

merged 1 commit into from Mar 16, 2022

Conversation

Miciah
Copy link
Contributor

@Miciah Miciah commented Feb 23, 2022

This is a manual cherry-pick of #705.

/assign @rfredette

@Miciah
Normalize the AWS internal LB annotation value
402af64 
The AWS cloud-provider implementation checks the
service.beta.kubernetes.io/aws-load-balancer-internal service annotation
to determine whether a service load-balancer (SLB) should be internal.  The
cloud-provider implementation recognizes both the value "0.0.0.0/0" and the
value "true" as indicating that the SLB should be internal.  OpenShift 4.7
and earlier use the value "0.0.0.0/0", and OpenShift 4.8 and later use the
value "true".  A service that was created on an older cluster might have
the value "0.0.0.0/0", which can cause comparisons that check for the
"true" value to return the wrong result.  This commit adds logic to
normalize the annotation value to "true".

Follow-up to commit 3abcba5
and commit 4cc59f5.

This commit fixes bug 2055470.

https://bugzilla.redhat.com/show_bug.cgi?id=2055470

* pkg/operator/controller/ingress/load_balancer_service.go
(ensureLoadBalancerService): Call the new
normalizeLoadBalancerServiceAnnotations method to normalize the AWS
internal LB annotation.
(normalizeLoadBalancerServiceAnnotations): New method.  Normalize the
service.beta.kubernetes.io/aws-load-balancer-internal service annotation by
replacing the value "0.0.0.0/0" with the value "true".
* test/e2e/operator_test.go (TestInternalLoadBalancer): Verify that the
operator updates the old "0.0.0.0/0" annotation value to "true".
@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Feb 23, 2022
@Miciah Miciah changed the title [release-4.10] Bug 2057518: Normalize the AWS internal LB annotation value [release-4.9] Bug 2057518: Normalize the AWS internal LB annotation value Feb 23, 2022
@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 23, 2022

@Miciah: This pull request references Bugzilla bug 2057518, which is invalid:

  • expected dependent Bugzilla bug 2056928 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.10] Bug 2057518: Normalize the AWS internal LB annotation value

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2022
@rfredette
Copy link
Contributor

/lgtm

/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah, rfredette

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Miciah Miciah added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 24, 2022
@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 24, 2022

@openshift-bot: This pull request references Bugzilla bug 2057518, which is invalid:

  • expected dependent Bugzilla bug 2056928 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Miciah
Copy link
Contributor Author

Miciah commented Feb 24, 2022

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 24, 2022

@Miciah: This pull request references Bugzilla bug 2057518, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2056928 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2056928 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
  • bug has dependents

Requesting review from QA contact:
/cc @lihongan

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from lihongan February 24, 2022 16:57
@quarterpin
Copy link

/label qe-approved
Verified via pre-merge test process. For more details refer to: https://bugzilla.redhat.com/show_bug.cgi?id=2057518#c2

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Mar 1, 2022
@lihongan
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 16, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 16, 2022

@Miciah: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit ad8b80d into openshift:release-4.9 Mar 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 16, 2022

@Miciah: All pull requests linked via external trackers have merged:

Bugzilla bug 2057518 has been moved to the MODIFIED state.

In response to this:

[release-4.9] Bug 2057518: Normalize the AWS internal LB annotation value

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@candita candita Awaiting requested review from candita

@frobware frobware Awaiting requested review from frobware

@lihongan lihongan Awaiting requested review from lihongan

Assignees

@rfredette rfredette

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Miciah @rfredette @openshift-bot @quarterpin @lihongan @openshift-merge-robot