Updating ose-cluster-ingress-operator images to be consistent with ART

[Miciah]

Reconciling with https://github.com/openshift/ocp-build-data/tree/b44f15ec9e84d1831eac81f8c757b3bed985dbeb/images/ose-cluster-ingress-operator.yml

This PR is based on #802 but additionally includes changes to the formatting of pkg/manifests/bindata.go that result from using the updated Go 1.19 builder image, as well as formatting changes to several other files to appease gofmt. Including these changes is necessary in order for the verify job to pass.

[Miciah]

Since this is just #802 plus formatting changes and #802 doesn't need a tracker, this PR shouldn't need a tracker either.
/approve
/label bugzilla/valid-bug

[openshift-ci]

@Miciah: Can not set label bugzilla/valid-bug: Must be member in one of these teams: [openshift-patch-managers openshift-staff-engineers]

In response to this:

Since this is just #802 plus formatting changes and #802 doesn't need a tracker, this PR shouldn't need a tracker either.
/approve
/label bugzilla/valid-bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Miciah]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Miciah]

e2e-aws-operator failed because TestUnmanagedDNSToManagedDNSInternalIngressController failed and one of the control-plane nodes did not come ready.
/test e2e-aws-operator

e2e-aws-ovn-single-node failed because of the following failures:

[sig-arch][bz-kube-apiserver][Late] Alerts alert/KubePodNotReady should not be at or above info in ns/openshift-kube-apiserver [Suite:openshift/conformance/parallel]
[sig-arch][bz-kube-controller-manager][Late] Alerts alert/KubePodNotReady should not be at or above info in ns/openshift-kube-controller-manager [Suite:openshift/conformance/parallel]
[sig-arch][bz-kube-scheduler][Late] Alerts alert/KubePodNotReady should not be at or above info in ns/openshift-kube-scheduler [Suite:openshift/conformance/parallel]

/test e2e-aws-ovn-single-node

e2e-aws-ovn-upgrade failed because of another KubePodNotReady issue.
/test e2e-aws-ovn-upgrade

e2e-gcp-ovn-serial failed because of KubePodNotReady errors as well as OVNKubernetesNorthboundDatabaseClusterMemberError, OVNKubernetesNorthboundDatabaseInboundConnectionMissing, OVNKubernetesNorthboundDatabaseOutboundConnectionMissing, OVNKubernetesSouthboundDatabaseClusterMemberError, OVNKubernetesSouthboundDatabaseInboundConnectionMissing, and OVNKubernetesSouthboundDatabaseOutboundConnectionMissing alerts.
/test e2e-gcp-ovn-serial

[Miciah]

https://issues.redhat.com/browse/TRT-589 is tracking KubeNotReady issues.

[Miciah]

e2e-aws-operator failed because various tests failed: TestUnmanagedDNSToManagedDNSInternalIngressController, TestManagedDNSToUnmanagedDNSIngressController, TestUnmanagedDNSToManagedDNSIngressController, TestAWSLBTypeChange, and TestInternalLoadBalancer, probably because kube-controller-manager (which provisions LBs) failed to roll out, along with kube-apiserver, kube-scheduler, and ovnkube-master.
/test e2e-aws-operator

e2e-aws-ovn-single-node failed because prometheus-operator is overly watchful:

: [sig-arch][Late] operators should not create watch channels very often [apigroup:config.openshift.io] [Suite:openshift/conformance/parallel]
Run #0: Failed
{  fail [github.com/openshift/origin/test/extended/apiserver/api_requests.go:453]: Expected
    <[]string | len:1, cap:1>: [
        "Operator \"prometheus-operator\" produces more watch requests than expected: watchrequestcount=215, upperbound=200, ratio=1.075",
    ]
to be empty
Ginkgo exit error 1: exit with code 1}
Run #1: Failed
{  fail [github.com/openshift/origin/test/extended/apiserver/api_requests.go:453]: Expected
    <[]string | len:1, cap:1>: [
        "Operator \"prometheus-operator\" produces more watch requests than expected: watchrequestcount=215, upperbound=200, ratio=1.075",
    ]
to be empty
Ginkgo exit error 1: exit with code 1}

/test e2e-aws-ovn-single-node

e2e-gcp-ovn-serial failed because of OVNKubernetes alerts, auth and console disruption, and an unhealthy etcd member.
/test e2e-gcp-ovn-serial

[Miciah]

e2e-gcp-ovn-serial failed because of OAuth and console disruption and an unhealthy etcd member.
/test e2e-gcp-ovn-serial

[alebedev87]

/lgtm

[Miciah]

/test all
now that #843 has merged.
/test e2e-azure-operator
/test e2e-gcp-operator

[Miciah]

e2e-aws-operator failed, and the ingress-operator logs show that the hosted zone could not be found:

2022-10-21T15:46:35.700Z	ERROR	operator.dns_controller	dns/controller.go:359	failed to publish DNS record to zone	{"record": {"dnsName":"*.apps.ci-op-s5ip724i-43abb.origin-ci-int-aws.dev.rhcloud.com.","targets":["af72772571fe849f88ae21931f161e7a-1427110984.us-west-1.elb.amazonaws.com"],"recordType":"CNAME","recordTTL":30,"dnsManagementPolicy":"Managed"}, "dnszone": {"tags":{"Name":"/errorci-op-s5ip724i-43abb-j4v5k-int","kubernetes.io/cluster/ci-op-s5ip724i-43abb-j4v5k":"owned"}}, "error": "failed to find hosted zone for record: no matching hosted zone found"}

Let's see whether this is an aberration.
/test e2e-aws-operator

[Miciah]

e2e-gcp-ovn-serial failed because disruption/ingress-to-oauth-server connection/new and disruption/ingress-to-console connection/new failed.
/test e2e-gcp-ovn-serial

[Miciah]

e2e-aws-operator failed because TestRouteMetricsControllerRouteAndNamespaceSelector failed and because kube-apiserver, kube-controller-manager, kube-scheduler, and network had difficulties rolling out pods.

TestRouteMetricsControllerRouteAndNamespaceSelector failed because an API call failed:

    route_metrics_test.go:325: failed to update route: Operation cannot be fulfilled on routes.route.openshift.io "route-rs-ns-foo-label": the object has been modified; please apply your changes to the latest version and try again

If this becomes a recurring issue, we could add some retry logic here:

cluster-ingress-operator/test/e2e/route_metrics_test.go

Lines 321 to 325 in 9742afc

	// updateRouteAndWaitForMetricsUpdate updates the Route and waits for metric to be updated to the expected value.
	func updateRouteAndWaitForMetricsUpdate(t *testing.T, route *routev1.Route, prometheusClient prometheusv1.API, shardName string, value int) {
	// Update the Route resource.
	if err := kclient.Update(context.TODO(), route); err != nil {
	t.Fatalf("failed to update route: %v", err)

Otherwise, might add retry logic there as part of a more comprehensive effort to add retries in order to increase resilience of E2E tests overall.
/test e2e-aws-operator

[Miciah]

e2e-aws-operator failed because TestUpdateDefaultIngressController failed and because authentication, kube-apiserver, kube-controller-manager, kube-scheduler, and storage had difficulties rolling out pods.

TestUpdateDefaultIngressController failed because a Kube API call failed:

    operator_test.go:508: failed to delete test secret: Delete "https://api.ci-op-0njv3kcw-43abb.origin-ci-int-aws.dev.rhcloud.com:6443/api/v1/namespaces/openshift-ingress/secrets/test-l28g7": read tcp 10.131.227.107:55492->52.5.128.156:6443: read: connection reset by peer

/test e2e-aws-operator

[Miciah]

e2e-aws-operator failed because kube-apiserver reported NodeInstallerProgressing.
/override ci/prow/e2e-aws-operator

[openshift-ci]

@Miciah: Overrode contexts on behalf of Miciah: ci/prow/e2e-aws-operator

In response to this:

e2e-aws-operator failed because kube-apiserver reported NodeInstallerProgressing.
/override ci/prow/e2e-aws-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@Miciah: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[Miciah]

#802 was automatically labeled so it could merge without a bug or epic. This PR likewise shouldn't require a bug or epic.
/label docs-approved
/label px-approved
/label qe-approved