OCPBUGS-10875: gateway-service-dns: Set DNS policy appropriately #934

Miciah · 2023-05-19T00:13:51Z

gateway-service-dns: Add test coverage for deletes

pkg/operator/controller/gateway-service-dns/controller_test.go (Test_Reconcile): Add labels to DNS records so that deleteStaleDNSRecordsForGateway doesn't filter them out. Verify that objects that are expected to be deleted are indeed deleted. Add a test case to verify that deletion works properly.
(fakeClientRecorder): Add "deleted" field.
(Create, Delete, Update): Log actions.
(Delete): Record deleted objects.

gateway-service-dns: Set DNS policy appropriately

When creating a DNSRecord CR for a gateway listener, set the DNS management policy to "Unmanaged" if the DNSRecord's domain is outside the cluster's base domain.

Before this change, the operator would attempt to create DNS records for gateway listeners even if they had domains outside of the cluster's base domain zone, resulting in "failed to publish DNS record to zone" errors.

pkg/operator/controller/gateway-service-dns/controller.go (Reconcile): Get the dns and infrastructure config objects, and pass them to ensureDNSRecordsForGateway.
(ensureDNSRecordsForGateway): Add infraConfig and dnsConfig parameters. Use them and the ManageDNSForDomain function to determine the appropriate policy (managed or unmanaged) for each DNS record, and pass that policy to EnsureDNSRecord.
pkg/resources/dnsrecord/dns.go (EnsureDNSRecord): Add a dnsPolicy parameter, and pass it to desiredDNSRecord.
(ManageDNSForDomain): Ignore trailing dots when comparing the given domain and the cluster's base domain.
pkg/resources/dnsrecord/dns_test.go (TestManageDNSForDomain): Add test cases for empty base domain and for various combinations of trailing dots on the domain or base domain.
pkg/operator/controller/gateway-service-dns/controller_test.go (Test_Reconcile): Add dnsConfig and infraConfig to existingObjects in test cases. Add a test case to verify that the DNS management policy is set to "Unmanaged" if the DNS name doesn't belong to the cluster's base domain.

openshift-ci-robot · 2023-05-19T00:13:56Z

@Miciah: This pull request references Jira Issue OCPBUGS-10875, which is invalid:

expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

When creating a DNSRecord CR for a gateway listener, set the DNS management policy to "Unmanaged" if the DNSRecord's domain is outside the cluster's base domain.

Before this change, the operator would attempt to create DNS records for gateway listeners even if they had domains outside of the cluster's base domain zone, resulting in "failed to publish DNS record to zone" errors.

pkg/operator/controller/gateway-service-dns/controller.go (Reconcile): Get the dns and infrastructure config objects, and pass them to ensureDNSRecordsForGateway.
(ensureDNSRecordsForGateway): Add infraConfig and dnsConfig parameters. Use them and the ManageDNSForDomain function to determine the appropriate policy (managed or unmanaged) for each DNS record, and pass that policy to EnsureDNSRecord.

pkg/resources/dnsrecord/dns.go (EnsureDNSRecord): Add a dnsPolicy parameter, and pass it to desiredDNSRecord.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Miciah · 2023-05-19T00:16:10Z

/jira refresh

openshift-ci-robot · 2023-05-19T00:16:16Z

@Miciah: This pull request references Jira Issue OCPBUGS-10875, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.0) matches configured target version for branch (4.14.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-05-19T18:19:54Z

@Miciah: This pull request references Jira Issue OCPBUGS-10875, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.0) matches configured target version for branch (4.14.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

In response to this:

gateway-service-dns: Add test coverage for deletes

pkg/operator/controller/gateway-service-dns/controller_test.go (Test_Reconcile): Add labels to DNS records so that deleteStaleDNSRecordsForGateway doesn't filter them out. Verify that objects that are expected to be deleted are indeed deleted. Add a test case to verify that deletion works properly.
(fakeClientRecorder): Add "deleted" field.
(Create, Delete, Update): Log actions.
(Delete): Record deleted objects.

gateway-service-dns: Set DNS policy appropriately

When creating a DNSRecord CR for a gateway listener, set the DNS management policy to "Unmanaged" if the DNSRecord's domain is outside the cluster's base domain.

Before this change, the operator would attempt to create DNS records for gateway listeners even if they had domains outside of the cluster's base domain zone, resulting in "failed to publish DNS record to zone" errors.

pkg/operator/controller/gateway-service-dns/controller.go (Reconcile): Get the dns and infrastructure config objects, and pass them to ensureDNSRecordsForGateway.
(ensureDNSRecordsForGateway): Add infraConfig and dnsConfig parameters. Use them and the ManageDNSForDomain function to determine the appropriate policy (managed or unmanaged) for each DNS record, and pass that policy to EnsureDNSRecord.

pkg/resources/dnsrecord/dns.go (EnsureDNSRecord): Add a dnsPolicy parameter, and pass it to desiredDNSRecord.

pkg/operator/controller/gateway-service-dns/controller_test.go (Test_Reconcile): Add dnsConfig and infraConfig to existingObjects in test cases. Add a test case to verify that the DNS management policy is set to "Unmanaged" if the DNS name doesn't belong to the cluster's base domain.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

candita · 2023-06-14T15:39:16Z

/retest-required

candita · 2023-06-21T21:02:29Z

/assign @gcs278

gcs278 · 2023-06-26T14:25:43Z

pkg/operator/controller/gateway-service-dns/controller_test.go

+			},
+			expectUpdate: []client.Object{},
+			expectDelete: []client.Object{},
+		},


Is it worth adding 2 simple test cases: one for dnsConfig is null and another for infraConfig is null and nothing should be created?

Done in https://github.com/openshift/cluster-ingress-operator/compare/038190ece2d957a26615bbc666ad9164a2e67846..0eb49fbfeccdb763ad5757025967393ac0f1465c.

Miciah · 2023-06-29T01:09:26Z

https://github.com/openshift/cluster-ingress-operator/compare/c5b6502afa09f81617c0955e10cd1dffed3ccdb1..8b20178b30c5e9516ac68e8c46649ba2b9d4b701 rebases for #949.

Miciah · 2023-06-29T01:17:09Z

Whoops, https://github.com/openshift/cluster-ingress-operator/compare/8b20178b30c5e9516ac68e8c46649ba2b9d4b701..038190ece2d957a26615bbc666ad9164a2e67846 re-adds code from #949 that got inadvertently got dropped in the rebase.

Miciah · 2023-06-29T01:18:27Z

https://github.com/openshift/cluster-ingress-operator/compare/038190ece2d957a26615bbc666ad9164a2e67846..0eb49fbfeccdb763ad5757025967393ac0f1465c adds test cases suggested in #934 (comment).

Miciah · 2023-06-29T01:19:07Z

I'll rebase again once #949 (comment) is resolved.

* pkg/operator/controller/gateway-service-dns/controller_test.go (Test_Reconcile): Add labels to DNS records so that deleteStaleDNSRecordsForGateway doesn't filter them out. Verify that objects that are expected to be deleted are indeed deleted. Add a test case to verify that deletion works properly. (fakeClientRecorder): Add "deleted" field. (Create, Delete, Update): Log actions. (Delete): Record deleted objects.

gcs278 · 2023-07-05T17:51:28Z

pkg/resources/dnsrecord/dns.go

@@ -229,11 +229,20 @@ func dnsRecordChanged(current, expected *iov1.DNSRecord) (bool, *iov1.DNSRecord)
 // once we know there are no users depending on this.
 // See https://bugzilla.redhat.com/show_bug.cgi?id=2041616
 func ManageDNSForDomain(domain string, status *configv1.PlatformStatus, dnsConfig *configv1.DNS) bool {
-	if len(domain) == 0 {
+	if len(domain) == 0 || len(dnsConfig.Spec.BaseDomain) == 0 {


Should we unit test this new change? BaseDomain = ""?

Added in https://github.com/openshift/cluster-ingress-operator/compare/26492dbda956f0542dbcb9abaec20535be13c56a..620c930bbb51728f597d6ae2db46d04a3974de1a.

gcs278 · 2023-07-05T17:53:35Z

pkg/resources/dnsrecord/dns.go

 		return false
 	}

 	mustContain := "." + dnsConfig.Spec.BaseDomain
+
+	// Ignore any trailing dot for comparison.


Should we unit test comparison of domains and base domains that end with .?

Added in https://github.com/openshift/cluster-ingress-operator/compare/26492dbda956f0542dbcb9abaec20535be13c56a..620c930bbb51728f597d6ae2db46d04a3974de1a.

When creating a DNSRecord CR for a gateway listener, set the DNS management policy to "Unmanaged" if the DNSRecord's domain is outside the cluster's base domain. Before this commit, the operator would attempt to create DNS records for gateway listeners even if they had domains outside of the cluster's base domain zone, resulting in "failed to publish DNS record to zone" errors. This commit fixes OCPBUGS-10875. https://issues.redhat.com/browse/OCPBUGS-10875 * pkg/operator/controller/gateway-service-dns/controller.go (Reconcile): Get the dns and infrastructure config objects, and pass them to ensureDNSRecordsForGateway. (ensureDNSRecordsForGateway): Add infraConfig and dnsConfig parameters. Use them and the ManageDNSForDomain function to determine the appropriate policy (managed or unmanaged) for each DNS record, and pass that policy to EnsureDNSRecord. * pkg/resources/dnsrecord/dns.go (EnsureDNSRecord): Add a dnsPolicy parameter, and pass it to desiredDNSRecord. (ManageDNSForDomain): Ignore trailing dots when comparing the given domain and the cluster's base domain. * pkg/resources/dnsrecord/dns_test.go (TestManageDNSForDomain): Add test cases for empty base domain and for various combinations of trailing dots on the domain or base domain. * pkg/operator/controller/gateway-service-dns/controller_test.go (Test_Reconcile): Add expectError to the test inputs, and assert that the expected error is returned if expectError is not empty. Add dnsConfig and infraConfig to existingObjects in test cases. Add test cases to verify that the reconciler returns the expected error if the cluster DNS config or cluster infrastructure config is not found. Add a test case to verify that the DNS management policy is set to "Unmanaged" if the DNS name doesn't belong to the cluster's base domain.

openshift-ci-robot · 2023-07-18T19:27:18Z

@Miciah: This pull request references Jira Issue OCPBUGS-10875, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.0) matches configured target version for branch (4.14.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

In response to this:

gateway-service-dns: Add test coverage for deletes

pkg/operator/controller/gateway-service-dns/controller_test.go (Test_Reconcile): Add labels to DNS records so that deleteStaleDNSRecordsForGateway doesn't filter them out. Verify that objects that are expected to be deleted are indeed deleted. Add a test case to verify that deletion works properly.
(fakeClientRecorder): Add "deleted" field.
(Create, Delete, Update): Log actions.
(Delete): Record deleted objects.

gateway-service-dns: Set DNS policy appropriately

When creating a DNSRecord CR for a gateway listener, set the DNS management policy to "Unmanaged" if the DNSRecord's domain is outside the cluster's base domain.

Before this change, the operator would attempt to create DNS records for gateway listeners even if they had domains outside of the cluster's base domain zone, resulting in "failed to publish DNS record to zone" errors.

pkg/operator/controller/gateway-service-dns/controller.go (Reconcile): Get the dns and infrastructure config objects, and pass them to ensureDNSRecordsForGateway.
(ensureDNSRecordsForGateway): Add infraConfig and dnsConfig parameters. Use them and the ManageDNSForDomain function to determine the appropriate policy (managed or unmanaged) for each DNS record, and pass that policy to EnsureDNSRecord.

pkg/resources/dnsrecord/dns.go (EnsureDNSRecord): Add a dnsPolicy parameter, and pass it to desiredDNSRecord.

pkg/resources/dnsrecord/dns_test.go (TestManageDNSForDomain): Add test cases for empty base domain and for various combinations of trailing dots on the domain or base domain.

pkg/operator/controller/gateway-service-dns/controller_test.go (Test_Reconcile): Add dnsConfig and infraConfig to existingObjects in test cases. Add a test case to verify that the DNS management policy is set to "Unmanaged" if the DNS name doesn't belong to the cluster's base domain.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-07-18T19:28:18Z

@Miciah: This pull request references Jira Issue OCPBUGS-10875, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.0) matches configured target version for branch (4.14.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

In response to this:

gateway-service-dns: Add test coverage for deletes

pkg/operator/controller/gateway-service-dns/controller_test.go (Test_Reconcile): Add labels to DNS records so that deleteStaleDNSRecordsForGateway doesn't filter them out. Verify that objects that are expected to be deleted are indeed deleted. Add a test case to verify that deletion works properly.
(fakeClientRecorder): Add "deleted" field.
(Create, Delete, Update): Log actions.
(Delete): Record deleted objects.

gateway-service-dns: Set DNS policy appropriately

When creating a DNSRecord CR for a gateway listener, set the DNS management policy to "Unmanaged" if the DNSRecord's domain is outside the cluster's base domain.

Before this change, the operator would attempt to create DNS records for gateway listeners even if they had domains outside of the cluster's base domain zone, resulting in "failed to publish DNS record to zone" errors.

pkg/operator/controller/gateway-service-dns/controller.go (Reconcile): Get the dns and infrastructure config objects, and pass them to ensureDNSRecordsForGateway.
(ensureDNSRecordsForGateway): Add infraConfig and dnsConfig parameters. Use them and the ManageDNSForDomain function to determine the appropriate policy (managed or unmanaged) for each DNS record, and pass that policy to EnsureDNSRecord.

pkg/resources/dnsrecord/dns.go (EnsureDNSRecord): Add a dnsPolicy parameter, and pass it to desiredDNSRecord.
(ManageDNSForDomain): Ignore trailing dots when comparing the given domain and the cluster's base domain.

pkg/resources/dnsrecord/dns_test.go (TestManageDNSForDomain): Add test cases for empty base domain and for various combinations of trailing dots on the domain or base domain.

pkg/operator/controller/gateway-service-dns/controller_test.go (Test_Reconcile): Add dnsConfig and infraConfig to existingObjects in test cases. Add a test case to verify that the DNS management policy is set to "Unmanaged" if the DNS name doesn't belong to the cluster's base domain.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Miciah · 2023-07-18T19:31:59Z

https://github.com/openshift/cluster-ingress-operator/compare/26492dbda956f0542dbcb9abaec20535be13c56a..620c930bbb51728f597d6ae2db46d04a3974de1a adds test cases requested in #934 (review).

Miciah · 2023-07-19T17:33:53Z

e2e-aws-ovn-serial failed on [sig-scheduling] Multi-AZ Clusters should spread the pods of a service across zones:

{  fail [test/e2e/scheduling/ubernetes_lite.go:178]: Pods were not evenly spread across zones.  0 in one zone and 10 in another zone
Expected
    <int>: 10
to be within 2 of ~
    <int>: 0
Error: exit with code 1
Ginkgo exit error 1: exit with code 1}

Search.ci isn't currently loading for me, so I cannot check whether this failure is occurring on other PRs.
/test e2e-aws-ovn-serial

e2e-hypershift failed. It isn't clear why. I see numerous errors in test output, but no actual test failure. I think the tests just timed out:

 {"component":"entrypoint","error":"process timed out","file":"k8s.io/test-infra/prow/entrypoint/run.go:79","func":"k8s.io/test-infra/prow/entrypoint.Options.Run","level":"error","msg":"Error executing test process","severity":"error","time":"2023-07-18T20:59:02Z"}

@enxebre, do you know how to diagnose these failures?
/test e2e-hypershift

gcs278 · 2023-08-02T15:59:18Z

Sorry for the delay, I missed the notifications on this one.

Updates look good, thanks.
/lgtm
/approve

openshift-ci · 2023-08-02T16:01:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gcs278

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [gcs278]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2023-08-02T18:29:16Z

/retest-required

Remaining retests: 0 against base HEAD ddba423 and 2 for PR HEAD 620c930 in total

openshift-ci-robot · 2023-08-04T00:55:44Z

/retest-required

Remaining retests: 0 against base HEAD 4e7b2da and 1 for PR HEAD 620c930 in total

Miciah · 2023-08-04T03:22:43Z

e2e-gcp-operator failed because must-gather failed.

Also, #968 merged, so we need to rerun all tests.
/test all.

openshift-ci · 2023-08-04T03:22:46Z

@Miciah: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test e2e-aws-operator
/test e2e-aws-ovn
/test e2e-aws-ovn-serial
/test e2e-aws-ovn-upgrade
/test e2e-azure-operator
/test e2e-gcp-operator
/test e2e-hypershift
/test images
/test unit
/test verify

The following commands are available to trigger optional jobs:

/test e2e-aws-ovn-single-node
/test e2e-azure-manual-oidc
/test e2e-azure-ovn
/test e2e-gcp-ovn

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-operator
pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-ovn
pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-ovn-serial
pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-ovn-single-node
pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-ovn-upgrade
pull-ci-openshift-cluster-ingress-operator-master-e2e-azure-operator
pull-ci-openshift-cluster-ingress-operator-master-e2e-azure-ovn
pull-ci-openshift-cluster-ingress-operator-master-e2e-gcp-operator
pull-ci-openshift-cluster-ingress-operator-master-e2e-gcp-ovn
pull-ci-openshift-cluster-ingress-operator-master-e2e-hypershift
pull-ci-openshift-cluster-ingress-operator-master-images
pull-ci-openshift-cluster-ingress-operator-master-unit
pull-ci-openshift-cluster-ingress-operator-master-verify

In response to this:

e2e-gcp-operator failed because must-gather failed.

Also, #968 merged, so we need to rerun all tests.
/test all.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Miciah · 2023-08-04T03:22:53Z

/test all

openshift-ci-robot · 2023-08-04T22:26:27Z

/retest-required

Remaining retests: 0 against base HEAD 833bc28 and 0 for PR HEAD 620c930 in total

openshift-ci-robot · 2023-08-05T02:26:23Z

/hold

Revision 620c930 was retested 3 times: holding

Miciah · 2023-08-05T19:38:03Z

e2e-aws-operator failed because must-gather failed.
/test e2e-aws-operator

e2e-aws-ovn-serial failed because [sig-storage] PersistentVolumes-local Stress with local volumes [Serial] should be able to process many pods and reuse local volumes failed:

{  fail [test/e2e/storage/persistent_volumes-local.go:522]: persistentvolumes "local-pvx9bhx" not found
Error: exit with code 1
Ginkgo exit error 1: exit with code 1}

This is a known issue: OCPBUGS-14930.
/test e2e-aws-ovn-seria

/hold cancel

Miciah · 2023-08-05T19:39:07Z

/test e2e-aws-ovn-serial

Miciah · 2023-08-05T19:48:39Z

/test e2e-aws-ovn-serial

openshift-ci · 2023-08-05T22:06:36Z

@Miciah: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2023-08-05T22:09:58Z

@Miciah: Jira Issue OCPBUGS-10875: All pull requests linked via external trackers have merged:

openshift/cluster-ingress-operator#934

Jira Issue OCPBUGS-10875 has been moved to the MODIFIED state.

In response to this:

gateway-service-dns: Add test coverage for deletes

pkg/operator/controller/gateway-service-dns/controller_test.go (Test_Reconcile): Add labels to DNS records so that deleteStaleDNSRecordsForGateway doesn't filter them out. Verify that objects that are expected to be deleted are indeed deleted. Add a test case to verify that deletion works properly.
(fakeClientRecorder): Add "deleted" field.
(Create, Delete, Update): Log actions.
(Delete): Record deleted objects.

gateway-service-dns: Set DNS policy appropriately

When creating a DNSRecord CR for a gateway listener, set the DNS management policy to "Unmanaged" if the DNSRecord's domain is outside the cluster's base domain.

Before this change, the operator would attempt to create DNS records for gateway listeners even if they had domains outside of the cluster's base domain zone, resulting in "failed to publish DNS record to zone" errors.

pkg/operator/controller/gateway-service-dns/controller.go (Reconcile): Get the dns and infrastructure config objects, and pass them to ensureDNSRecordsForGateway.
(ensureDNSRecordsForGateway): Add infraConfig and dnsConfig parameters. Use them and the ManageDNSForDomain function to determine the appropriate policy (managed or unmanaged) for each DNS record, and pass that policy to EnsureDNSRecord.

pkg/resources/dnsrecord/dns.go (EnsureDNSRecord): Add a dnsPolicy parameter, and pass it to desiredDNSRecord.
(ManageDNSForDomain): Ignore trailing dots when comparing the given domain and the cluster's base domain.

pkg/resources/dnsrecord/dns_test.go (TestManageDNSForDomain): Add test cases for empty base domain and for various combinations of trailing dots on the domain or base domain.

pkg/operator/controller/gateway-service-dns/controller_test.go (Test_Reconcile): Add dnsConfig and infraConfig to existingObjects in test cases. Add a test case to verify that the DNS management policy is set to "Unmanaged" if the DNS name doesn't belong to the cluster's base domain.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from alebedev87 and frobware May 19, 2023 00:14

openshift-ci bot requested a review from lihongan May 19, 2023 00:16

Miciah force-pushed the OCPBUGS-10875-gateway-service-dns-set-DNS-policy-appropriately branch from 26ca122 to c5b6502 Compare May 19, 2023 18:19

openshift-ci bot assigned gcs278 Jun 21, 2023

gcs278 reviewed Jun 26, 2023

View reviewed changes

Miciah mentioned this pull request Jun 29, 2023

[release-4.13] OCPBUGS-15434: Create valid DNS names for Gateway API on GCP #953

Closed

Miciah marked this pull request as draft June 29, 2023 00:26

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 29, 2023

Miciah force-pushed the OCPBUGS-10875-gateway-service-dns-set-DNS-policy-appropriately branch from c5b6502 to 8b20178 Compare June 29, 2023 01:08

Miciah force-pushed the OCPBUGS-10875-gateway-service-dns-set-DNS-policy-appropriately branch from 8b20178 to 038190e Compare June 29, 2023 01:16

Miciah force-pushed the OCPBUGS-10875-gateway-service-dns-set-DNS-policy-appropriately branch from 038190e to 0eb49fb Compare June 29, 2023 01:18

Miciah force-pushed the OCPBUGS-10875-gateway-service-dns-set-DNS-policy-appropriately branch from 0eb49fb to 26492db Compare June 29, 2023 23:47

openshift-ci bot requested review from knobunc and rfredette June 29, 2023 23:49

gcs278 reviewed Jul 5, 2023

View reviewed changes

Miciah force-pushed the OCPBUGS-10875-gateway-service-dns-set-DNS-policy-appropriately branch from 26492db to 7a32d62 Compare July 18, 2023 19:25

Miciah force-pushed the OCPBUGS-10875-gateway-service-dns-set-DNS-policy-appropriately branch from 7a32d62 to 620c930 Compare July 18, 2023 19:26

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2023

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2023

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2023

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2023

openshift-merge-robot merged commit 2be8f80 into openshift:master Aug 5, 2023
14 checks passed

Miciah mentioned this pull request Aug 5, 2023

OCPBUGS-14995: desiredRouterDeployment: Set HostPort if needed #947

Merged

OCPBUGS-10875: gateway-service-dns: Set DNS policy appropriately #934

OCPBUGS-10875: gateway-service-dns: Set DNS policy appropriately #934

Conversation

Miciah commented May 19, 2023 • edited

gateway-service-dns: Add test coverage for deletes

gateway-service-dns: Set DNS policy appropriately

openshift-ci-robot commented May 19, 2023

Miciah commented May 19, 2023

openshift-ci-robot commented May 19, 2023

openshift-ci-robot commented May 19, 2023

gateway-service-dns: Add test coverage for deletes

gateway-service-dns: Set DNS policy appropriately

candita commented Jun 14, 2023

candita commented Jun 21, 2023

gcs278 Jun 26, 2023

Choose a reason for hiding this comment

Miciah Jun 29, 2023

Choose a reason for hiding this comment

Miciah commented Jun 29, 2023

Miciah commented Jun 29, 2023

Miciah commented Jun 29, 2023

Miciah commented Jun 29, 2023 • edited

gcs278 Jul 5, 2023

Choose a reason for hiding this comment

Miciah Jul 18, 2023

Choose a reason for hiding this comment

gcs278 Jul 5, 2023

Choose a reason for hiding this comment

Miciah Jul 18, 2023

Choose a reason for hiding this comment

openshift-ci-robot commented Jul 18, 2023

gateway-service-dns: Add test coverage for deletes

gateway-service-dns: Set DNS policy appropriately

openshift-ci-robot commented Jul 18, 2023

gateway-service-dns: Add test coverage for deletes

gateway-service-dns: Set DNS policy appropriately

Miciah commented Jul 18, 2023

Miciah commented Jul 19, 2023

gcs278 commented Aug 2, 2023

openshift-ci bot commented Aug 2, 2023

openshift-ci-robot commented Aug 2, 2023

openshift-ci-robot commented Aug 4, 2023

Miciah commented Aug 4, 2023

openshift-ci bot commented Aug 4, 2023

Miciah commented Aug 4, 2023

openshift-ci-robot commented Aug 4, 2023

openshift-ci-robot commented Aug 5, 2023

Miciah commented Aug 5, 2023

Miciah commented Aug 5, 2023

Miciah commented Aug 5, 2023

openshift-ci bot commented Aug 5, 2023

openshift-ci-robot commented Aug 5, 2023

gateway-service-dns: Add test coverage for deletes

gateway-service-dns: Set DNS policy appropriately

Miciah commented May 19, 2023 •

edited

Miciah commented Jun 29, 2023 •

edited