Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-13963: Bump vendors k8s libraries to 0.27.2 #936

Merged
merged 1 commit into from May 30, 2023

Conversation

gcs278
Copy link
Contributor

@gcs278 gcs278 commented May 23, 2023

OCPBUGS-13963: Bump vendors k8s libraries to 0.27.2

go get k8s.io/api@v0.27.2
go get sigs.k8s.io/controller-runtime@v0.15.0
go mod tidy
go mod vendor

go.mod: Bumped to GO 1.20, controller-runtime, api, and dependencies.
pkg/operator/client/client.go: Created HTTPClient for updated for NewDiscoveryRESTMapper function definitiont.
pkg/operator/controller/canary/controller.go,
pkg/operator/controller/certificate-publisher/controller.go,
pkg/operator/controller/certificate/controller.go,
pkg/operator/controller/clientca-configmap/controller.go,
pkg/operator/controller/configurable-route/controller.go,
pkg/operator/controller/crl/controller.go,
pkg/operator/controller/dns/controller.go,
pkg/operator/controller/gateway-service-dns/controller.go,
pkg/operator/controller/gatewayapi/controller.go,
pkg/operator/controller/gatewayclass/controller.go,
pkg/operator/controller/ingress/controller.go,
pkg/operator/controller/ingressclass/controller.go,
pkg/operator/controller/route-metrics/controller.go,
pkg/operator/controller/status/controller.go,
pkg/operator/controller/sync-http-error-code-configmap/controller.go: Updates for source.Kind conversion from type to function, MapFunc definition update to add context argument, handler.EnqueueRequestForOwner definition update for scheme and mapper.
pkg/operator/operator.go: Removed deprecated MultiNamespacedCacheBuilder for cache.Options{}. Added override to client.Options.Cache in NewClient function so client won't use cache. Removed deprecated Namespace manager.Options{} field.
pkg/operator/controller/dns/controller_test.go: TestMigrateDNSRecordStatus: Updated to NewClientBuilder(). controller-runtime v0.15.0 required add
WithStatusSubresource() to create an object with a status. Added t.Run()

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 23, 2023
@openshift-ci-robot
Copy link
Contributor

@gcs278: This pull request references Jira Issue OCPBUGS-13963, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ShudiLi

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

OCPBUGS-13963: Bump vendors k8s libraries to 0.27.2

go get k8s.io/api@v0.27.2
go get sigs.k8s.io/controller-runtime@v0.15.0
go mod tidy
go mod vendor

go.mod: Bumped to GO 1.20

pkg/operator/client/client.go:
pkg/operator/controller/canary/controller.go:
pkg/operator/controller/certificate-publisher/controller.go: pkg/operator/controller/certificate/controller.go: pkg/operator/controller/clientca-configmap/controller.go: pkg/operator/controller/configurable-route/controller.go: pkg/operator/controller/crl/controller.go:
pkg/operator/controller/dns/controller.go:
pkg/operator/controller/gateway-service-dns/controller.go: pkg/operator/controller/gatewayapi/controller.go: pkg/operator/controller/gatewayclass/controller.go: pkg/operator/controller/ingress/controller.go:
pkg/operator/controller/ingressclass/controller.go: pkg/operator/controller/route-metrics/controller.go: pkg/operator/controller/status/controller.go:
pkg/operator/controller/sync-http-error-code-configmap/controller.go: pkg/operator/operator.go: Updates for controller-runtime v0.15.0

pkg/operator/controller/dns/controller_test.go: TestMigrateDNSRecordStatus: Updated to NewClientBuilder(). controller-runtime v0.15.0 required add WithStatusSubresource() to create an object with a status. Added t.Run().

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gcs278
Copy link
Contributor Author

gcs278 commented May 24, 2023

E2E installation failure. Looks like ingress operator won't start with:

2023-05-23T20:45:45.130321593Z 2023-05-23T20:45:45.130Z ERROR   operator.main   cobra/command.go:920    error starting  {"error": "failed fetching infrastructure config: the cache is not started, can not read   objects"}

Reading through release notes now...

@gcs278
Copy link
Contributor Author

gcs278 commented May 24, 2023

/hold
since ingress-operator is failing to start

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2023
@candita
Copy link
Contributor

candita commented May 24, 2023

/assign @alebedev87

@gcs278 gcs278 force-pushed the k8s-1.27 branch 2 times, most recently from e08007a to 3e14ebe Compare May 24, 2023 19:38
@gcs278
Copy link
Contributor Author

gcs278 commented May 24, 2023

/retest
unrelated failures

@gcs278
Copy link
Contributor Author

gcs278 commented May 25, 2023

disruption issue
/retest

@gcs278 gcs278 force-pushed the k8s-1.27 branch 4 times, most recently from 8df9ad4 to f8398f5 Compare May 25, 2023 18:37
Copy link
Contributor

@alebedev87 alebedev87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just 2 last remarks.

@gcs278 gcs278 force-pushed the k8s-1.27 branch 2 times, most recently from d911c1c to 050e4d1 Compare May 25, 2023 21:41
@openshift-ci-robot
Copy link
Contributor

@gcs278: This pull request references Jira Issue OCPBUGS-13963, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ShudiLi

In response to this:

OCPBUGS-13963: Bump vendors k8s libraries to 0.27.2

go get k8s.io/api@v0.27.2
go get sigs.k8s.io/controller-runtime@v0.15.0
go mod tidy
go mod vendor

go.mod: Bumped to GO 1.20, controller-runtime, api, and dependencies.
pkg/operator/client/client.go: Created HTTPClient for updated for
NewDiscoveryRESTMapper function definitiont.
pkg/operator/controller/canary/controller.go,
pkg/operator/controller/certificate-publisher/controller.go,
pkg/operator/controller/certificate/controller.go,
pkg/operator/controller/clientca-configmap/controller.go,
pkg/operator/controller/configurable-route/controller.go,
pkg/operator/controller/crl/controller.go,
pkg/operator/controller/dns/controller.go,
pkg/operator/controller/gateway-service-dns/controller.go,
pkg/operator/controller/gatewayapi/controller.go,
pkg/operator/controller/gatewayclass/controller.go,
pkg/operator/controller/ingress/controller.go,
pkg/operator/controller/ingressclass/controller.go,
pkg/operator/controller/route-metrics/controller.go,
pkg/operator/controller/status/controller.go,
pkg/operator/controller/sync-http-error-code-configmap/controller.go:
Updates for source.Kind conversion from type to function, MapFunc definition update to
add context argument, handler.EnqueueRequestForOwner definition update for scheme and mapper.
pkg/operator/operator.go: Removed deprecated MultiNamespacedCacheBuilder for
cache.Options{}. Added override to client.Options.Cache in NewClient function so client
won't use cache. Removed deprecated Namespace manager.Options{} field.
pkg/operator/controller/dns/controller_test.go: TestMigrateDNSRecordStatus:
Updated to NewClientBuilder(). controller-runtime v0.15.0 required add
WithStatusSubresource() to create an object with a status. Added t.Run(

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@gcs278: This pull request references Jira Issue OCPBUGS-13963, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ShudiLi

In response to this:

OCPBUGS-13963: Bump vendors k8s libraries to 0.27.2

go get k8s.io/api@v0.27.2
go get sigs.k8s.io/controller-runtime@v0.15.0
go mod tidy
go mod vendor

go.mod: Bumped to GO 1.20, controller-runtime, api, and dependencies.
pkg/operator/client/client.go: Created HTTPClient for updated for NewDiscoveryRESTMapper function definitiont.
pkg/operator/controller/canary/controller.go,
pkg/operator/controller/certificate-publisher/controller.go,
pkg/operator/controller/certificate/controller.go,
pkg/operator/controller/clientca-configmap/controller.go,
pkg/operator/controller/configurable-route/controller.go,
pkg/operator/controller/crl/controller.go,
pkg/operator/controller/dns/controller.go,
pkg/operator/controller/gateway-service-dns/controller.go,
pkg/operator/controller/gatewayapi/controller.go,
pkg/operator/controller/gatewayclass/controller.go,
pkg/operator/controller/ingress/controller.go,
pkg/operator/controller/ingressclass/controller.go,
pkg/operator/controller/route-metrics/controller.go,
pkg/operator/controller/status/controller.go,
pkg/operator/controller/sync-http-error-code-configmap/controller.go: Updates for source.Kind conversion from type to function, MapFunc definition update to add context argument, handler.EnqueueRequestForOwner definition update for scheme and mapper.
pkg/operator/operator.go: Removed deprecated MultiNamespacedCacheBuilder for cache.Options{}. Added override to client.Options.Cache in NewClient function so client won't use cache. Removed deprecated Namespace manager.Options{} field.
pkg/operator/controller/dns/controller_test.go: TestMigrateDNSRecordStatus: Updated to NewClientBuilder(). controller-runtime v0.15.0 required add
WithStatusSubresource() to create an object with a status. Added t.Run()

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gcs278
Copy link
Contributor Author

gcs278 commented May 26, 2023

/unhold
Fixed the issue with ingress operator not starting

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2023
@gcs278
Copy link
Contributor Author

gcs278 commented May 26, 2023

TestAWSELBConnectionIdleTimeout failure on aws and TestInternalLoadBalancer failure on gcp, both known failures.
/retest-required

@gcs278
Copy link
Contributor Author

gcs278 commented May 26, 2023

TestAWSELBConnectionIdleTimeout for aws
TestUnmanagedDNSToManagedDNSInternalIngressController and TestAllowedSourceRanges for GCP 🤔
/retest-required

go get k8s.io/api@v0.27.2
go get sigs.k8s.io/controller-runtime@v0.15.0
go mod tidy
go mod vendor

`go.mod`: Bumped to GO 1.20, controller-runtime, api, and dependencies.
`pkg/operator/client/client.go`: Created HTTPClient for updated for
   NewDiscoveryRESTMapper function definitiont.
`pkg/operator/controller/canary/controller.go`,
`pkg/operator/controller/certificate-publisher/controller.go`,
`pkg/operator/controller/certificate/controller.go`,
`pkg/operator/controller/clientca-configmap/controller.go`,
`pkg/operator/controller/configurable-route/controller.go`,
`pkg/operator/controller/crl/controller.go`,
`pkg/operator/controller/dns/controller.go`,
`pkg/operator/controller/gateway-service-dns/controller.go`,
`pkg/operator/controller/gatewayapi/controller.go`,
`pkg/operator/controller/gatewayclass/controller.go`,
`pkg/operator/controller/ingress/controller.go`,
`pkg/operator/controller/ingressclass/controller.go`,
`pkg/operator/controller/route-metrics/controller.go`,
`pkg/operator/controller/status/controller.go`,
`pkg/operator/controller/sync-http-error-code-configmap/controller.go`:
   Updates for source.Kind conversion from type to function, MapFunc definition
   update to add context argument, handler.EnqueueRequestForOwner definition update
   for scheme and mapper.
`pkg/operator/operator.go`: Removed deprecated MultiNamespacedCacheBuilder for
   cache.Options{}. Added override to client.Options.Cache in NewClient function
   so client won't use cache. Removed deprecated Namespace manager.Options{} field.
`pkg/operator/controller/dns/controller_test.go`: TestMigrateDNSRecordStatus:
   Updated to `NewClientBuilder()`. controller-runtime v0.15.0 required add
`WithStatusSubresource()` to create an object with a status. Added t.Run().
@alebedev87
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2023
@alebedev87
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 90d2fea and 2 for PR HEAD 8f98c61 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2023

@gcs278: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn 8f98c61 link false /test e2e-gcp-ovn
ci/prow/e2e-azure-ovn 8f98c61 link false /test e2e-azure-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Miciah
Copy link
Contributor

Miciah commented May 30, 2023

e2e-aws-operator failed because TestAWSELBConnectionIdleTimeout failed, which is a known CI flake (OCPBUGS-13810).
/override ci/prow/e2e-aws-operator

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 30, 2023

@Miciah: Overrode contexts on behalf of Miciah: ci/prow/e2e-aws-operator

In response to this:

e2e-aws-operator failed because TestAWSELBConnectionIdleTimeout failed, which is a known CI flake (OCPBUGS-13810).
/override ci/prow/e2e-aws-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gcs278
Copy link
Contributor Author

gcs278 commented May 30, 2023

e2e-aws-ovn-upgrade failed on

event happened 26 times, something is wrong: ns/openshift-monitoring statefulset/alertmanager-main hmsg/765701326a - pathological/true reason/RecreatingFailedPod StatefulSet openshift-monitoring/alertmanager-main is recreating failed Pod alertmanager-main-1 From: 20:33:58Z To: 20:33:59Z result=reject }

I don't think it's related.
/test e2e-aws-ovn-upgrade

@Miciah
Copy link
Contributor

Miciah commented May 30, 2023

Investigating the e2e-gcp-ovn and e2e-azure-ovn failures may be useful for improving product stability, but note that those failing jobs are currently optional and thus do not block this PR from merging.

@gcs278
Copy link
Contributor Author

gcs278 commented May 30, 2023

True, I habitually started overlooking them, so it's a good reminder to review.
e2e-azure-ovn failed due to what seems like a plumbing issue:

Failed to create pod sandbox: rpc error: code = Unknown desc = failed to create pod network sandbox k8s_testpod_e2e-test-tuning-4klqk_2916f65f-80f7-4f40-9328-61950bee7442_0(0037cd0a4bf8dc72c8f40325a3f8b8dc16ad2dc962958362614427b0301b87bd): error adding pod e2e-test-tuning-4klqk_testpod to CNI network "multus-cni-network": plugin type="multus" name="multus-cni-network" failed (add): [e2e-test-tuning-4klqk/testpod/2916f65f-80f7-4f40-9328-61950bee7442:tuningnad]: error adding container to network "tuningnad": plugin type="tuning" failed (add): Sysctl net.ipv4.conf.IFNAME.accept_local is not allowed. Only the following sysctls are allowed: [^net.ipv4.conf.IFNAME.accept_redirects$ ^net.ipv4.conf.IFNAME.accept_source_route$ ^net.ipv4.conf.IFNAME.arp_accept$ ^net.ipv4.conf.IFNAME.arp_notify$ ^net.ipv4.conf.IFNAME.disable_policy$ ^net.ipv4.conf.IFNAME.secure_redirects$ ^net.ipv4.conf.IFNAME.send_redirects$ ^net.ipv6.conf.IFNAME.accept_ra$ ^net.ipv6.conf.IFNAME.accept_redirects$ ^net.ipv6.conf.IFNAME.accept_source_route$ ^net.ipv6.conf.IFNAME.arp_accept$ ^net.ipv6.conf.IFNAME.arp_notify$ ^net.ipv6.neigh.IFNAME.base_reachable_time_ms$ ^net.ipv6.neigh.IFNAME.retrans_time_ms$]

And same thing with e2e-gcp-ovn:

Failed to create pod sandbox: rpc error: code = Unknown desc = failed to create pod network sandbox k8s_testpod_e2e-test-tuning-rwlhz_a784e766-9e17-4ae9-a66c-70c439ae5f49_0(778270cdf3c7330296b34c2c1ed9eae99ffa391dfe290c1974cbb8b72f3a8d19): error adding pod e2e-test-tuning-rwlhz_testpod to CNI network "multus-cni-network": plugin type="multus" name="multus-cni-network" failed (add): [e2e-test-tuning-rwlhz/testpod/a784e766-9e17-4ae9-a66c-70c439ae5f49:tuningnad]: error adding container to network "tuningnad": plugin type="tuning" failed (add): Sysctl net.ipv4.conf.IFNAME.accept_local is not allowed. Only the following sysctls are allowed: [^net.ipv4.conf.IFNAME.accept_redirects$ ^net.ipv4.conf.IFNAME.accept_source_route$ ^net.ipv4.conf.IFNAME.arp_accept$ ^net.ipv4.conf.IFNAME.arp_notify$ ^net.ipv4.conf.IFNAME.disable_policy$ ^net.ipv4.conf.IFNAME.secure_redirects$ ^net.ipv4.conf.IFNAME.send_redirects$ ^net.ipv6.conf.IFNAME.accept_ra$ ^net.ipv6.conf.IFNAME.accept_redirects$ ^net.ipv6.conf.IFNAME.accept_source_route$ ^net.ipv6.conf.IFNAME.arp_accept$ ^net.ipv6.conf.IFNAME.arp_notify$ ^net.ipv6.neigh.IFNAME.base_reachable_time_ms$ ^net.ipv6.neigh.IFNAME.retrans_time_ms$]

Discussion here: https://redhat-internal.slack.com/archives/CDCP2LA9L/p1685464016247739

@Miciah
Copy link
Contributor

Miciah commented May 30, 2023

/refresh

@openshift-merge-robot openshift-merge-robot merged commit 5725691 into openshift:master May 30, 2023
12 of 14 checks passed
@openshift-ci-robot
Copy link
Contributor

@gcs278: Jira Issue OCPBUGS-13963: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-13963 has been moved to the MODIFIED state.

In response to this:

OCPBUGS-13963: Bump vendors k8s libraries to 0.27.2

go get k8s.io/api@v0.27.2
go get sigs.k8s.io/controller-runtime@v0.15.0
go mod tidy
go mod vendor

go.mod: Bumped to GO 1.20, controller-runtime, api, and dependencies.
pkg/operator/client/client.go: Created HTTPClient for updated for NewDiscoveryRESTMapper function definitiont.
pkg/operator/controller/canary/controller.go,
pkg/operator/controller/certificate-publisher/controller.go,
pkg/operator/controller/certificate/controller.go,
pkg/operator/controller/clientca-configmap/controller.go,
pkg/operator/controller/configurable-route/controller.go,
pkg/operator/controller/crl/controller.go,
pkg/operator/controller/dns/controller.go,
pkg/operator/controller/gateway-service-dns/controller.go,
pkg/operator/controller/gatewayapi/controller.go,
pkg/operator/controller/gatewayclass/controller.go,
pkg/operator/controller/ingress/controller.go,
pkg/operator/controller/ingressclass/controller.go,
pkg/operator/controller/route-metrics/controller.go,
pkg/operator/controller/status/controller.go,
pkg/operator/controller/sync-http-error-code-configmap/controller.go: Updates for source.Kind conversion from type to function, MapFunc definition update to add context argument, handler.EnqueueRequestForOwner definition update for scheme and mapper.
pkg/operator/operator.go: Removed deprecated MultiNamespacedCacheBuilder for cache.Options{}. Added override to client.Options.Cache in NewClient function so client won't use cache. Removed deprecated Namespace manager.Options{} field.
pkg/operator/controller/dns/controller_test.go: TestMigrateDNSRecordStatus: Updated to NewClientBuilder(). controller-runtime v0.15.0 required add
WithStatusSubresource() to create an object with a status. Added t.Run()

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants