Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-16762: Bump openshift/api for container.maxLength fix #979

Conversation

Miciah
Copy link
Contributor

@Miciah Miciah commented Oct 6, 2023

Bump to github.com/openshift/api@bbe1a26bbafcc8f3abcc72418d8d9492a68d44c6 to get a fix for the validation of the IngressController API's spec.logging.access.destination.container.maxLength field.

As a side effect, this PR also bumps k8s.io dependencies to 0.28.2.

  • go.mod: Update.
  • go.sum:
  • manifests/00-custom-resource-definition.yaml:
  • vendor/*: Regenerate.

Note: This IngressController API change will be backported to 4.14.0 to ensure that we do not break compatibility.

Bump to github.com/openshift/api@bbe1a26bbafcc8f3abcc72418d8d9492a68d44c6
to get a fix for the validation of the IngressController API's
spec.logging.access.destination.container.maxLength field.

As a side effect, this commit also bumps k8s.io dependencies to 0.28.2.

This commit fixes OCPBUGS-16762.

https://issues.redhat.com//browse/OCPBUGS-16762

* go.mod: Update.
* go.sum:
* manifests/00-custom-resource-definition.yaml:
* vendor/*: Regenerate.
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 6, 2023
@openshift-ci-robot
Copy link
Contributor

@Miciah: This pull request references Jira Issue OCPBUGS-16762, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bump to github.com/openshift/api@bbe1a26bbafcc8f3abcc72418d8d9492a68d44c6 to get a fix for the validation of the IngressController API's spec.logging.access.destination.container.maxLength field.

As a side effect, this PR also bumps k8s.io dependencies to 0.28.2.

  • go.mod: Update.
  • go.sum:
  • manifests/00-custom-resource-definition.yaml:
  • vendor/*: Regenerate.

Note: This IngressController API change will be backported to 4.14.0 to ensure that we do not break compatibility.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from knobunc and miheer October 6, 2023 15:21
@candita
Copy link
Contributor

candita commented Oct 6, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: candita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2023

@Miciah: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 35f202f link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@candita
Copy link
Contributor

candita commented Oct 6, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 6, 2023
@openshift-ci-robot
Copy link
Contributor

@candita: This pull request references Jira Issue OCPBUGS-16762, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @melvinjoseph86

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot merged commit d8a3150 into openshift:master Oct 6, 2023
13 of 14 checks passed
@openshift-ci-robot
Copy link
Contributor

@Miciah: Jira Issue OCPBUGS-16762: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-16762 has been moved to the MODIFIED state.

In response to this:

Bump to github.com/openshift/api@bbe1a26bbafcc8f3abcc72418d8d9492a68d44c6 to get a fix for the validation of the IngressController API's spec.logging.access.destination.container.maxLength field.

As a side effect, this PR also bumps k8s.io dependencies to 0.28.2.

  • go.mod: Update.
  • go.sum:
  • manifests/00-custom-resource-definition.yaml:
  • vendor/*: Regenerate.

Note: This IngressController API change will be backported to 4.14.0 to ensure that we do not break compatibility.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2023-10-09-101435

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2023-11-07-162411

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants