Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.14] OCPBUGS-21898: test/e2e: Add test case for 2000000 maxConnections #984

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #983

/assign frobware

This commit adds a test case to verify that the maxConnections setting
can be configured with the absolute upper limit of 2000000, as defined
by the API

% oc explain ingresscontroller.spec.tuningOptions.maxConnections
KIND:     IngressController
VERSION:  operator.openshift.io/v1

FIELD:    maxConnections <integer>

DESCRIPTION:
     maxConnections defines the maximum number of simultaneous
     connections that can be established per HAProxy process.
     Increasing this value allows each ingress controller pod to
     handle more connections but at the cost of additional system
     resources being consumed. Permitted values are: empty, 0, -1, and
     the range 2000-2000000.

This change requires openshift/router#527.

Fixes: https://issues.redhat.com/browse/OCPBUGS-21803.
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-21803 with correct target version. Will retitle the PR to link to the clone.
/retitle [release-4.14] OCPBUGS-21898: test/e2e: Add test case for 2000000 maxConnections

In response to this:

This is an automated cherry-pick of #983

/assign frobware

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.14] OCPBUGS-21803: test/e2e: Add test case for 2000000 maxConnections [release-4.14] OCPBUGS-21898: test/e2e: Add test case for 2000000 maxConnections Oct 18, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 18, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-21898, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-21803 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-21803 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

Requesting review from QA contact:
/cc @lihongan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #983

/assign frobware

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@frobware
Copy link
Contributor

/assign @Miciah

@Miciah
Copy link
Contributor

Miciah commented Oct 18, 2023

/approve
/lgtm
This is a low-risk change to E2E to verify that the associated blocker bug really is fixed.
/label backport-risk-assessed

@Miciah
Copy link
Contributor

Miciah commented Oct 18, 2023

Note that e2e-*-operator jobs are expected to fail until openshift/router#528 merges.

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 18, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2023
@wallylewis
Copy link

/retest

@frobware
Copy link
Contributor

frobware commented Oct 19, 2023

/retest

Assuming this clears CI, the PR is missing cherry-pick-approved.

@knobunc
Copy link

knobunc commented Oct 19, 2023

/label cherry-pick-approved

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2023

@knobunc: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knobunc knobunc added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). labels Oct 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 7e10070 into openshift:release-4.14 Oct 19, 2023
14 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-21898: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-21898 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #983

/assign frobware

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.14.0-0.nightly-2023-10-22-172722

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants