Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPVE-780: annotate credentials request manifests #995

Merged
merged 1 commit into from Dec 9, 2023

Conversation

qJkee
Copy link
Contributor

@qJkee qJkee commented Nov 13, 2023

Add capability annotations to cloud credentials requests

Add capability annotations to cloud credentials requests
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 13, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 13, 2023

@qJkee: This pull request references OCPVE-780 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Add capability annotations to cloud credentials requests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2023
@qJkee
Copy link
Contributor Author

qJkee commented Dec 5, 2023

/retest

1 similar comment
@qJkee
Copy link
Contributor Author

qJkee commented Dec 6, 2023

/retest

@qJkee qJkee changed the title [WIP] OCPVE-780: annotate credentials request manifests OCPVE-780: annotate credentials request manifests Dec 6, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 6, 2023
@alebedev87
Copy link
Contributor

/assign

I assign myself after the discussion with Bulat.

@alebedev87
Copy link
Contributor

Leaving a link to the Slack discussion thread just in case: https://redhat-internal.slack.com/archives/CCH60A77E/p1701965812945069.

@alebedev87
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2023
Copy link
Contributor

openshift-ci bot commented Dec 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2023
@qJkee
Copy link
Contributor Author

qJkee commented Dec 7, 2023

/label docs-approved
/label px-approved
Labelling because this is a dependency PR and all the things are completed for the main PR

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Dec 7, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d49eeec and 2 for PR HEAD 9bc4c71 in total

@fxierh
Copy link

fxierh commented Dec 8, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Dec 8, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 8, 2023

@qJkee: This pull request references OCPVE-780 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Add capability annotations to cloud credentials requests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alebedev87
Copy link
Contributor

/override e2e-gcp-operator

Do I have rights?!

e2e-gcp-operator fails only on TestUnmanagedDNSToManagedDNSInternalIngressController which will be addressed in the dedicated bug.

Copy link
Contributor

openshift-ci bot commented Dec 8, 2023

@alebedev87: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • e2e-gcp-operator

Only the following failed contexts/checkruns were expected:

  • ci/prow/e2e-aws-operator
  • ci/prow/e2e-aws-ovn
  • ci/prow/e2e-aws-ovn-serial
  • ci/prow/e2e-aws-ovn-single-node
  • ci/prow/e2e-aws-ovn-upgrade
  • ci/prow/e2e-azure-operator
  • ci/prow/e2e-azure-ovn
  • ci/prow/e2e-gcp-operator
  • ci/prow/e2e-gcp-ovn
  • ci/prow/e2e-hypershift
  • ci/prow/images
  • ci/prow/unit
  • ci/prow/verify
  • pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-operator
  • pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-ovn
  • pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-ovn-serial
  • pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-ovn-single-node
  • pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-ovn-upgrade
  • pull-ci-openshift-cluster-ingress-operator-master-e2e-azure-operator
  • pull-ci-openshift-cluster-ingress-operator-master-e2e-azure-ovn
  • pull-ci-openshift-cluster-ingress-operator-master-e2e-gcp-operator
  • pull-ci-openshift-cluster-ingress-operator-master-e2e-gcp-ovn
  • pull-ci-openshift-cluster-ingress-operator-master-e2e-hypershift
  • pull-ci-openshift-cluster-ingress-operator-master-images
  • pull-ci-openshift-cluster-ingress-operator-master-unit
  • pull-ci-openshift-cluster-ingress-operator-master-verify
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override e2e-gcp-operator

Do I have rights?!

e2e-gcp-operator fails only on TestUnmanagedDNSToManagedDNSInternalIngressController which will be addressed in the dedicated bug.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alebedev87
Copy link
Contributor

/override ci/prow/e2e-gcp-operator

Copy link
Contributor

openshift-ci bot commented Dec 8, 2023

@alebedev87: Overrode contexts on behalf of alebedev87: ci/prow/e2e-azure-ovn

In response to this:

/override ci/prow/e2e-azure-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Dec 8, 2023

@alebedev87: Overrode contexts on behalf of alebedev87: ci/prow/e2e-gcp-operator

In response to this:

/override ci/prow/e2e-gcp-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alebedev87
Copy link
Contributor

/test e2e-aws-ovn-upgrade

Installation failed.

@alebedev87
Copy link
Contributor

/test e2e-hypershift

@qJkee
Copy link
Contributor Author

qJkee commented Dec 8, 2023

/retest-required

@qJkee
Copy link
Contributor Author

qJkee commented Dec 8, 2023

/retest-required

Test fails are not related to the PR

@qJkee
Copy link
Contributor Author

qJkee commented Dec 9, 2023

/retest-required

Copy link
Contributor

openshift-ci bot commented Dec 9, 2023

@qJkee: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 9a87287 into openshift:master Dec 9, 2023
14 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-ingress-operator-container-v4.16.0-202312091832.p0.g9a87287.assembly.stream for distgit ose-cluster-ingress-operator.
All builds following this will include this PR.

@qJkee
Copy link
Contributor Author

qJkee commented Dec 10, 2023

/cherry-pick release-4.15

@openshift-cherrypick-robot

@qJkee: new pull request created: #1005

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants