Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1921139: Revert "remove override for fast cert rotation for release" #1147

Merged
merged 1 commit into from Jun 17, 2021
Merged

Bug 1921139: Revert "remove override for fast cert rotation for release" #1147

merged 1 commit into from Jun 17, 2021

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Jun 9, 2021 •
edited

Inverse of #1143 for master branch during development of 4.9.

@sttts sttts force-pushed the sttts-fast-rotation-aggregator-client-signer-4.8-master branch from 6f33d38 to 7077436 Compare June 9, 2021 18:12
@sttts sttts changed the title Reenable: force cert rotation every couple days for development: aggregator-client-signer Bug 1921139 : Reverte "remove override for fast cert rotation for release" Jun 9, 2021
@sttts sttts changed the title Bug 1921139 : Reverte "remove override for fast cert rotation for release" Bug 1921139 : Revert "remove override for fast cert rotation for release" Jun 9, 2021
@sttts
Copy link
Contributor Author

sttts commented Jun 9, 2021

/hold cancel

Merge after master has reopened.

@mfojtik
Copy link
Member

mfojtik commented Jun 9, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2021
@openshift-ci openshift-ci bot mentioned this pull request Jun 11, 2021
Merged
@mfojtik
Copy link
Member

mfojtik commented Jun 14, 2021

/retest
/approve

@sttts sttts force-pushed the sttts-fast-rotation-aggregator-client-signer-4.8-master branch from 7077436 to b04c97e Compare June 14, 2021 15:36
@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels Jun 14, 2021
@mfojtik
Copy link
Member

mfojtik commented Jun 14, 2021

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mfojtik
Copy link
Member

mfojtik commented Jun 14, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 14, 2021

@mfojtik: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik mfojtik changed the title Bug 1921139 : Revert "remove override for fast cert rotation for release" Bug 1921139: Revert "remove override for fast cert rotation for release" Jun 14, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 14, 2021

@sttts: This pull request references Bugzilla bug 1921139, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "4.8.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1921139: Revert "remove override for fast cert rotation for release"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik
Copy link
Member

mfojtik commented Jun 14, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 14, 2021

@mfojtik: This pull request references Bugzilla bug 1921139, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik
Copy link
Member

mfojtik commented Jun 14, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 14, 2021

@mfojtik: This pull request references Bugzilla bug 1921139, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @wangke19

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 14, 2021
@openshift-ci openshift-ci bot requested a review from wangke19 June 14, 2021 15:39
@hexfusion
Copy link
Contributor

/retest

@sttts
Copy link
Contributor Author

sttts commented Jun 14, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

16 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sttts
Copy link
Contributor Author

sttts commented Jun 17, 2021

/retest

@mfojtik
Copy link
Member

mfojtik commented Jun 17, 2021

/override ci/prow/e2e-gcp-operator
/override ci/prow/e2e-upgrade

First has multus problem that is already reported and known.
Second failure seems to be related to SCC (auth team know).

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 17, 2021

@mfojtik: Overrode contexts on behalf of mfojtik: ci/prow/e2e-gcp-operator, ci/prow/e2e-upgrade

In response to this:

/override ci/prow/e2e-gcp-operator
/override ci/prow/e2e-upgrade

First has multus problem that is already reported and known.
Second failure seems to be related to SCC (auth team know).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik mfojtik merged commit f5d0b9e into openshift:master Jun 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 17, 2021

@sttts: All pull requests linked via external trackers have merged:

Bugzilla bug 1921139 has been moved to the MODIFIED state.

In response to this:

Bug 1921139: Revert "remove override for fast cert rotation for release"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangke19 wangke19 Awaiting requested review from wangke19

Assignees

@mfojtik mfojtik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sttts @mfojtik @hexfusion @openshift-bot