Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1956081: add sigterm handler to insecurereadyz #1149

Merged
merged 1 commit into from Jun 19, 2021
Merged

Bug 1956081: add sigterm handler to insecurereadyz #1149

merged 1 commit into from Jun 19, 2021

Conversation

rphillips
Copy link
Contributor

This PR reopens #1130 to add graceful termination shutdown to the readyz endpoint. Originally we thought the bug had been fully fixed.

@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jun 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2021

@rphillips: This pull request references Bugzilla bug 195608, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to target the "4.9.0" release, but it targets "---" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is CLOSED (INSUFFICIENT_DATA) instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 195608: add sigterm handler to insecurereadyz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 16, 2021
@openshift-ci openshift-ci bot requested review from soltysh and sttts June 16, 2021 14:51
@rphillips
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2021

@rphillips: This pull request references Bugzilla bug 195608, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to target the "4.9.0" release, but it targets "---" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is CLOSED (INSUFFICIENT_DATA) instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rphillips rphillips changed the title Bug 195608: add sigterm handler to insecurereadyz Bug 1956081: add sigterm handler to insecurereadyz Jun 16, 2021
@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2021

@rphillips: This pull request references Bugzilla bug 1956081, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (schoudha@redhat.com), skipping review request.

In response to this:

Bug 1956081: add sigterm handler to insecurereadyz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 16, 2021
@rphillips rphillips force-pushed the fixes/add_sigterm_handler_to_insecurereadyz branch from 7bb6f55 to 1f6efcc Compare June 16, 2021 15:33
@sttts
Copy link
Contributor

sttts commented Jun 16, 2021

/lgtm
/approve

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 16, 2021
@rphillips rphillips force-pushed the fixes/add_sigterm_handler_to_insecurereadyz branch from 1f6efcc to 0835c53 Compare June 16, 2021 15:42
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2021
@rphillips
Copy link
Contributor Author

/test k8s-e2e-gcp

@sttts
Copy link
Contributor

sttts commented Jun 16, 2021

/retest
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rphillips, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@romfreiman
Copy link

/test e2e-aws-single-node

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 17, 2021

@romfreiman: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test e2e-aws
  • /test e2e-aws-serial
  • /test e2e-gcp-operator
  • /test e2e-gcp-operator-encryption
  • /test e2e-gcp-operator-encryption-perf
  • /test e2e-gcp-operator-encryption-rotation
  • /test e2e-metal-single-node-live-iso
  • /test e2e-upgrade
  • /test images
  • /test k8s-e2e-gcp
  • /test k8s-e2e-gcp-serial
  • /test unit
  • /test verify
  • /test verify-deps

Use /test all to run the following jobs:

  • pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-aws
  • pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-aws-serial
  • pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-gcp-operator
  • pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-upgrade
  • pull-ci-openshift-cluster-kube-apiserver-operator-master-images
  • pull-ci-openshift-cluster-kube-apiserver-operator-master-k8s-e2e-gcp
  • pull-ci-openshift-cluster-kube-apiserver-operator-master-k8s-e2e-gcp-serial
  • pull-ci-openshift-cluster-kube-apiserver-operator-master-unit
  • pull-ci-openshift-cluster-kube-apiserver-operator-master-verify
  • pull-ci-openshift-cluster-kube-apiserver-operator-master-verify-deps

In response to this:

/test e2e-aws-single-node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@rphillips
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@nee1esh
Copy link

nee1esh commented Jun 18, 2021

/test e2e-gcp-operator

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 6edd064 into openshift:master Jun 19, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 19, 2021

@rphillips: All pull requests linked via external trackers have merged:

Bugzilla bug 1956081 has been moved to the MODIFIED state.

In response to this:

Bug 1956081: add sigterm handler to insecurereadyz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nee1esh
Copy link

nee1esh commented Jun 19, 2021

/cherrypick release-4.8

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 19, 2021
Merged
@openshift-cherrypick-robot
Copy link

@nee1esh: new pull request created: #1154

In response to this:

/cherrypick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh Awaiting requested review from soltysh

@sttts sttts Awaiting requested review from sttts

Assignees

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@rphillips @sttts @openshift-bot @romfreiman @nee1esh @openshift-cherrypick-robot @openshift-merge-robot