Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove observing token timeouts #1161

Merged
merged 1 commit into from Jul 3, 2021
Merged

remove observing token timeouts #1161

merged 1 commit into from Jul 3, 2021

Conversation

stlaz
Copy link
Member

@stlaz stlaz commented Jun 23, 2021

Token timeouts are no longer relevant for the kube-apiserver as
the authenticator moved to oauth-apiserver in 4.8

/assign @deads2k
/cc @s-urbaniak

@stlaz
remove observing token timeouts
2610749 
Token timeouts are no longer relevant for the kube-apiserver as
the authenticator moved to oauth-apiserver in 4.8
@openshift-ci openshift-ci bot requested a review from s-urbaniak June 23, 2021 07:41
@s-urbaniak
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2021
@deads2k
Copy link
Contributor

deads2k commented Jul 2, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, s-urbaniak, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 3, 2021

@stlaz: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws 2610749 link /test e2e-aws
ci/prow/e2e-aws-serial 2610749 link /test e2e-aws-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b7dc933 into openshift:master Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

Assignees

@s-urbaniak s-urbaniak

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@stlaz @s-urbaniak @deads2k @openshift-bot @openshift-merge-robot