Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable apiextensions.k8s.io/v1beta1 and admissionregistration.k8s.io/v1beta1 #1162

Merged
merged 2 commits into from Jul 2, 2021
Merged

disable apiextensions.k8s.io/v1beta1 and admissionregistration.k8s.io/v1beta1 #1162

merged 2 commits into from Jul 2, 2021

Conversation

atiratree
Copy link
Member

to disable it even before we hit k8s 1.22

@openshift-ci openshift-ci bot requested review from deads2k and sttts June 23, 2021 17:43
@atiratree atiratree force-pushed the disable-apiregistration-beta branch from 674ff5b to ce52f80 Compare June 24, 2021 10:07
@atiratree atiratree changed the title disable apiregistration.k8s.io/v1beta1 disable apiextensions.k8s.io/v1beta1 Jun 24, 2021
@atiratree
Copy link
Member Author

/retest

@atiratree
Copy link
Member Author

fix for the origin tests: openshift/origin#26269

soltysh
soltysh approved these changes Jun 25, 2021
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold
until we get that origin PR merged

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 25, 2021
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 25, 2021
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2021
@atiratree atiratree changed the title disable apiextensions.k8s.io/v1beta1 disable apiextensions.k8s.io/v1beta1 and admissionregistration.k8s.io/v1beta1 Jun 25, 2021
@soltysh
Copy link
Member

soltysh commented Jun 25, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 25, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atiratree, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 25, 2021

@atiratree: The /retest command does not accept any targets.
The following commands are available to trigger jobs:

  • /test e2e-aws
  • /test e2e-aws-serial
  • /test e2e-gcp-operator
  • /test e2e-gcp-operator-encryption
  • /test e2e-gcp-operator-encryption-perf
  • /test e2e-gcp-operator-encryption-rotation
  • /test e2e-metal-single-node-live-iso
  • /test e2e-upgrade
  • /test images
  • /test k8s-e2e-gcp
  • /test k8s-e2e-gcp-serial
  • /test unit
  • /test verify
  • /test verify-deps

Use /test all to run the following jobs:

  • pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-aws
  • pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-aws-serial
  • pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-gcp-operator
  • pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-upgrade
  • pull-ci-openshift-cluster-kube-apiserver-operator-master-images
  • pull-ci-openshift-cluster-kube-apiserver-operator-master-k8s-e2e-gcp
  • pull-ci-openshift-cluster-kube-apiserver-operator-master-k8s-e2e-gcp-serial
  • pull-ci-openshift-cluster-kube-apiserver-operator-master-unit
  • pull-ci-openshift-cluster-kube-apiserver-operator-master-verify
  • pull-ci-openshift-cluster-kube-apiserver-operator-master-verify-deps

In response to this:

/retest ci/prow/e2e-aws
/retest ci/prow/e2e-upgrade
/retest ci/prow/k8s-e2e-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@atiratree
Copy link
Member Author

/test e2e-aws
/test e2e-upgrade
/test k8s-e2e-gcp

@atiratree
Copy link
Member Author

/test e2e-upgrade
/test k8s-e2e-gcp

@soltysh
Copy link
Member

soltysh commented Jun 28, 2021

/retest

3 similar comments
@atiratree
Copy link
Member Author

/retest

@atiratree
Copy link
Member Author

/retest

@atiratree
Copy link
Member Author

/retest

@atiratree
Copy link
Member Author

I think after this one we should be good to go openshift/origin#26280

@atiratree
Copy link
Member Author

/retest

1 similar comment
@atiratree
Copy link
Member Author

/retest

@atiratree
Copy link
Member Author

/hold cancel
/retest

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sttts
Copy link
Contributor

sttts commented Jul 1, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@soltysh
Copy link
Member

soltysh commented Jul 2, 2021

The upgrade failures seemed to be related with a problem that was fixed in this revert openshift/cluster-monitoring-operator#1259

@soltysh
Copy link
Member

soltysh commented Jul 2, 2021

/test k8s-e2e-gcp

@soltysh
Copy link
Member

soltysh commented Jul 2, 2021

/test e2e-aws

@soltysh
Copy link
Member

soltysh commented Jul 2, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit a6cd2ad into openshift:master Jul 2, 2021
@atiratree atiratree mentioned this pull request Jul 7, 2021
Merged
@atiratree atiratree mentioned this pull request Sep 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@sttts sttts Awaiting requested review from sttts

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@atiratree @soltysh @openshift-bot @sttts @openshift-merge-robot