Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

staticpod/installer: get rid of sleep in sync loop #1183

Merged
merged 2 commits into from Jul 23, 2021
Merged

staticpod/installer: get rid of sleep in sync loop #1183

merged 2 commits into from Jul 23, 2021

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Jul 23, 2021

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 23, 2021
@openshift-ci openshift-ci bot requested review from deads2k and mfojtik July 23, 2021 07:15
@sttts
Copy link
Contributor Author

sttts commented Jul 23, 2021

/retest

@sttts sttts force-pushed the sttts-staticpod-installer-sleep branch from 5b721f0 to 88c46c1 Compare July 23, 2021 09:51
@sttts sttts changed the title WIP: staticpod/installer: get rid of sleep in sync loop staticpod/installer: get rid of sleep in sync loop Jul 23, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 23, 2021
@sttts
Copy link
Contributor Author

sttts commented Jul 23, 2021

/retest

infra

@sttts
Copy link
Contributor Author

sttts commented Jul 23, 2021

/retest

@p0lyn0mial
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2021
@tkashem
Copy link
Contributor

tkashem commented Jul 23, 2021

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, sttts, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 67d1c96 into openshift:master Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@tkashem tkashem

@p0lyn0mial p0lyn0mial

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sttts @p0lyn0mial @tkashem @openshift-bot @openshift-merge-robot