Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2033784: set kube-apiserver degraded=true if webhook matches a virtual resource #1249

Merged
merged 1 commit into from Jan 7, 2022
Merged

Bug 2033784: set kube-apiserver degraded=true if webhook matches a virtual resource #1249

merged 1 commit into from Jan 7, 2022

Conversation

sanchezl
Copy link
Contributor

@sanchezl sanchezl commented Nov 2, 2021 •
edited

Add new condition: VirtualResourceAdmissionDegraded
Add new reason: AdmissionWebhookMatches

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 2, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 2, 2021
@sanchezl sanchezl force-pushed the webhook-degraded-virtual-resource branch 2 times, most recently from 4ef1863 to 143e4e4 Compare November 3, 2021 19:09
@sanchezl
Copy link
Contributor Author

sanchezl commented Nov 3, 2021

/test all

@sanchezl sanchezl marked this pull request as ready for review November 4, 2021 01:45
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 4, 2021
@sanchezl
Copy link
Contributor Author

sanchezl commented Nov 5, 2021

/retest

@sanchezl sanchezl force-pushed the webhook-degraded-virtual-resource branch 2 times, most recently from 99a3840 to 6b0674b Compare November 16, 2021 19:29
@sanchezl sanchezl force-pushed the webhook-degraded-virtual-resource branch from 6b0674b to c69e9e5 Compare November 19, 2021 04:42
sttts
sttts reviewed Nov 19, 2021
View reviewed changes
pkg/operator/webhooksupportabilitycontroller/conditions.go Outdated

// DynamicAdmissionWebhookMatchesReason indicates that a dynamic admission webhook matches
// a virtual resource.
DynamicAdmissionWebhookMatchesReason = "DynamicAdmissionWebhookMatches"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure I would understand this in a real cluster. would drop the "dynamic". VirtualResourceAdmissionWebHook

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 21, 2021
@sanchezl sanchezl force-pushed the webhook-degraded-virtual-resource branch from c69e9e5 to 4889e85 Compare December 3, 2021 01:44
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 3, 2021
@sanchezl sanchezl force-pushed the webhook-degraded-virtual-resource branch 2 times, most recently from 454d9ef to 45f142e Compare December 10, 2021 20:15
@sanchezl
Copy link
Contributor Author

/retest

@sanchezl sanchezl force-pushed the webhook-degraded-virtual-resource branch from 45f142e to a99232f Compare December 16, 2021 14:26
@sanchezl
Copy link
Contributor Author

/retest-required

@sanchezl
Copy link
Contributor Author

/retest

2 similar comments
@sanchezl
Copy link
Contributor Author

/retest

@sanchezl
Copy link
Contributor Author

/retest

@tkashem
Copy link
Contributor

tkashem commented Dec 17, 2021

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2021
@tkashem
Copy link
Contributor

tkashem commented Dec 17, 2021

/retest

@benluddy
Copy link
Contributor

/lgtm

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

13 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@benluddy
Copy link
Contributor

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2021
@sanchezl
Copy link
Contributor Author

/retest

2 similar comments
@sanchezl
Copy link
Contributor Author

/retest

@sanchezl
Copy link
Contributor Author

/retest

@sanchezl
Copy link
Contributor Author

/retest-required

@sanchezl sanchezl removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 7, 2022 •
edited

@sanchezl: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-operator-disruptive-single-node a99232f link false /test e2e-aws-operator-disruptive-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5435d65 into openshift:master Jan 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 7, 2022

@sanchezl: All pull requests linked via external trackers have merged:

Bugzilla bug 2033784 has been moved to the MODIFIED state.

In response to this:

Bug 2033784: set kube-apiserver degraded=true if webhook matches a virtual resource

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttts sttts sttts left review comments

@deads2k deads2k Awaiting requested review from deads2k

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

@wangke19 wangke19 Awaiting requested review from wangke19

Assignees

@benluddy benluddy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sanchezl @tkashem @benluddy @openshift-bot @sttts @openshift-merge-robot