Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unnecessary service annotations #1257

Merged
merged 1 commit into from Nov 25, 2021
Merged

remove unnecessary service annotations #1257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 0 additions & 3 deletions bindata/assets/kube-apiserver/svc.yaml
View file
Open in desktop
Expand Up @@ -3,9 +3,6 @@ kind: Service
metadata:
namespace: openshift-kube-apiserver
name: apiserver
annotations:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but you're missing labels which are being matched here: https://github.com/openshift/cluster-kube-apiserver-operator/blob/master/manifests/0000_90_kube-apiserver-operator_03_servicemonitor.yaml#L30-L32

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's actually wrong. We're scraping the metrics from default namespace kubernetes service. So just ignore my comment here.

prometheus.io/scrape: "true"
prometheus.io/scheme: https
spec:
type: ClusterIP
selector:
Expand Down