Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-13763: dont log jwt tokens #1499

Merged
merged 2 commits into from Jun 28, 2023
Merged

OCPBUGS-13763: dont log jwt tokens #1499

merged 2 commits into from Jun 28, 2023

Conversation

ibihim
Copy link
Contributor

@ibihim ibihim commented May 25, 2023

What

Bump library-go to openshift/library-go#1523.

Why

It removes token from the logging.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels May 25, 2023
@openshift-ci-robot
Copy link

@ibihim: This pull request references Jira Issue OCPBUGS-13342, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to target the "4.13.z" version, but it targets "4.13.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Done) instead
  • expected Jira Issue OCPBUGS-13342 to depend on a bug targeting a version in 4.14.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What

Bump library-go to openshift/library-go#1523.

Why

It removes token from the logging.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 25, 2023
@openshift-ci openshift-ci bot requested review from deads2k and mfojtik May 25, 2023 12:52
@ibihim ibihim force-pushed the OCPBUGS-13342-dont_log_jwt_tokens branch from 262d307 to ee9abcf Compare May 25, 2023 14:52
@dinhxuanvu
Copy link
Member

Waiting for openshift/library-go#1533

@ibihim
bump library-go
f834943 
Signed-off-by: Krzysztof Ostrowski <kostrows@redhat.com>
@ibihim
go mod vendor
1e913dc 
Signed-off-by: Krzysztof Ostrowski <kostrows@redhat.com>
@ibihim ibihim force-pushed the OCPBUGS-13342-dont_log_jwt_tokens branch from ee9abcf to 1e913dc Compare June 8, 2023 09:37
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2023

@ibihim: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-operator-disruptive-single-node 1e913dc link false /test e2e-aws-operator-disruptive-single-node
ci/prow/e2e-gcp-operator-single-node 1e913dc link false /test e2e-gcp-operator-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ibihim
Copy link
Contributor Author

ibihim commented Jun 8, 2023

/retest-required

dgrisonnet
dgrisonnet approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@dgrisonnet dgrisonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, ibihim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2023
@dgrisonnet
Copy link
Member

@ibihim the bug attached to this PR seems to be closed. Should we perhaps also close this PR?

@ibihim ibihim changed the title OCPBUGS-13342: dont log jwt tokens OCPBUGS-13763: dont log jwt tokens Jun 28, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 28, 2023
@openshift-ci-robot
Copy link

@ibihim: This pull request references Jira Issue OCPBUGS-13763, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-2765 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-2765 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @gkarager

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What

Bump library-go to openshift/library-go#1523.

Why

It removes token from the logging.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gkarager June 28, 2023 08:38
@ibihim
Copy link
Contributor Author

ibihim commented Jun 28, 2023

@dgrisonnet, I think the jira got closed and another got re-opened. I changed the target Jira.

@stlaz
Copy link
Member

stlaz commented Jun 28, 2023

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 28, 2023
@gangwgr
Copy link

gangwgr commented Jun 28, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 28, 2023
@openshift-merge-robot openshift-merge-robot merged commit 0b4e454 into openshift:release-4.13 Jun 28, 2023
12 of 14 checks passed
@openshift-ci-robot
Copy link

@ibihim: Jira Issue OCPBUGS-13763: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-13763 has not been moved to the MODIFIED state.

In response to this:

What

Bump library-go to openshift/library-go#1523.

Why

It removes token from the logging.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ibihim ibihim deleted the OCPBUGS-13342-dont_log_jwt_tokens branch June 29, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrisonnet dgrisonnet dgrisonnet approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@mfojtik mfojtik Awaiting requested review from mfojtik

@gkarager gkarager Awaiting requested review from gkarager

Assignees

@xingxingxia xingxingxia

@dgrisonnet dgrisonnet

@wangke19 wangke19

@gangwgr gangwgr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@ibihim @openshift-ci-robot @dinhxuanvu @dgrisonnet @stlaz @gangwgr @xingxingxia @openshift-merge-robot @wangke19