Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-14940: api_performance_dashboard: show apiserver_longrunning_requests metric #1511

Merged
merged 1 commit into from Jun 20, 2023

Conversation

p0lyn0mial
Copy link
Contributor

It looks like the previous metric used in the dashboard (apiserver_longrunning_gauge) metric was depreciated in 1.23 (upstream) - kubernetes/kubernetes#103441

The new metric is apiserver_longrunning_requests(used in this PR) - https://github.com/kubernetes/kubernetes/pull/103799/files

The old metric was removed in kubernetes/kubernetes@7313970
and at the same time the new metrics was promoted to "STABLE" level.

the prevoius apiserver_longrunning_gauge metric was depreciated
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 19, 2023
@openshift-ci-robot
Copy link

@p0lyn0mial: This pull request references Jira Issue OCPBUGS-14940, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

It looks like the previous metric used in the dashboard (apiserver_longrunning_gauge) metric was depreciated in 1.23 (upstream) - kubernetes/kubernetes#103441

The new metric is apiserver_longrunning_requests(used in this PR) - https://github.com/kubernetes/kubernetes/pull/103799/files

The old metric was removed in kubernetes/kubernetes@7313970
and at the same time the new metrics was promoted to "STABLE" level.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2023
@p0lyn0mial
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 19, 2023
@openshift-ci-robot
Copy link

@p0lyn0mial: This pull request references Jira Issue OCPBUGS-14940, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from wangke19 June 19, 2023 12:28
@p0lyn0mial
Copy link
Contributor Author

/assign @dgrisonnet

Copy link
Member

@dgrisonnet dgrisonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dgrisonnet,p0lyn0mial]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a1de1b1 and 2 for PR HEAD 86d866e in total

@p0lyn0mial
Copy link
Contributor Author

/test e2e-aws-ovn-serial

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 20, 2023

@p0lyn0mial: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 86d866e link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-operator-disruptive-single-node 86d866e link false /test e2e-aws-operator-disruptive-single-node
ci/prow/e2e-gcp-operator-single-node 86d866e link false /test e2e-gcp-operator-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@p0lyn0mial
Copy link
Contributor Author

For the record: I think that the perf-dashboard is also used by the openshift-apiserver. So the fix will be automatically applied to oas as well.

@p0lyn0mial
Copy link
Contributor Author

/test e2e-aws-ovn-serial

@openshift-merge-robot openshift-merge-robot merged commit adcfcbe into openshift:master Jun 20, 2023
12 of 15 checks passed
@openshift-ci-robot
Copy link

@p0lyn0mial: Jira Issue OCPBUGS-14940: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-14940 has been moved to the MODIFIED state.

In response to this:

It looks like the previous metric used in the dashboard (apiserver_longrunning_gauge) metric was depreciated in 1.23 (upstream) - kubernetes/kubernetes#103441

The new metric is apiserver_longrunning_requests(used in this PR) - https://github.com/kubernetes/kubernetes/pull/103799/files

The old metric was removed in kubernetes/kubernetes@7313970
and at the same time the new metrics was promoted to "STABLE" level.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants