Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api_performance_dashboard: show apiserver_request_total instead of apiserver_dropped_requests #1520

Merged
merged 1 commit into from Jun 23, 2023
Merged

api_performance_dashboard: show apiserver_request_total instead of apiserver_dropped_requests #1520

merged 1 commit into from Jun 23, 2023

Conversation

p0lyn0mial
Copy link
Contributor

@p0lyn0mial p0lyn0mial commented Jun 23, 2023 •
edited

the prevoius apiserver_dropped_requests metric was depreciated in kubernetes/kubernetes#110337

xref: #1518

@p0lyn0mial
api_performance_dashboard: show apiserver_request_total instead of ap…
2bf134c 
…iserver_dropped_requests

the prevoius apiserver_dropped_requests metric was depreciated
@p0lyn0mial
Copy link
Contributor Author

/assign @dgrisonnet

@openshift-ci openshift-ci bot requested review from soltysh and tkashem June 23, 2023 12:34
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2023
dgrisonnet
dgrisonnet approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@dgrisonnet dgrisonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dgrisonnet,p0lyn0mial]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2023

@p0lyn0mial: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 2bf134c link false /test e2e-aws-ovn-single-node
ci/prow/e2e-gcp-operator-single-node 2bf134c link false /test e2e-gcp-operator-single-node
ci/prow/e2e-aws-operator-disruptive-single-node 2bf134c link false /test e2e-aws-operator-disruptive-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit c9191b1 into openshift:master Jun 23, 2023
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrisonnet dgrisonnet dgrisonnet approved these changes

@soltysh soltysh Awaiting requested review from soltysh

@tkashem tkashem Awaiting requested review from tkashem

Assignees

@dgrisonnet dgrisonnet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@p0lyn0mial @dgrisonnet @openshift-merge-robot