New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.13] OCPBUGS-15853: pkg/operator/configobserver: check that the serving certificate refer… #1522
Conversation
…ence exists before applying Ensure that .spec.servingCerts.namedCertificates[*].servingCertificate.Name exists before applying. This prevents a typo or a missing/inaccessible certificate from being referenced in kube-apiserver pod and prevents crashlooping and recovery operation
@openshift-cherrypick-robot: Jira Issue OCPBUGS-8404 has been cloned as Jira Issue OCPBUGS-15853. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-15853, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
2 similar comments
/retest |
/retest |
/ocpbugs cc-qa |
Pre-merge verified the bug successfully, the related test results see https://issues.redhat.com/browse/OCPBUGS-15853?focusedId=22668572&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-22668572 |
/label qe-approved |
/retest |
@dgrisonnet not sure if you can PTAL. Thanks in advance. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
@tkashem could you please have a look at this PR and add the |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrisonnet, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label cherry-pick-approved |
/label backport-risk-assessed |
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest-required |
64248a8
into
openshift:release-4.13
@openshift-cherrypick-robot: Jira Issue OCPBUGS-15853: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-15853 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.13 |
@wangke19: base branch (release-4.13) needs to differ from target branch (release-4.13) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.12 |
@wangke19: new pull request created: #1571 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.11 |
@wangke19: new pull request created: #1616 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #1482
/assign palonsoro