Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverts DynamicResourceAllocation enablement on techpreview #1540

Merged
merged 2 commits into from Aug 22, 2023
Merged

Reverts DynamicResourceAllocation enablement on techpreview #1540

merged 2 commits into from Aug 22, 2023

Conversation

stbenjam
Copy link
Member

Reverts #1538, #1536; tracked by OCPBUGS-17967

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

We believe this PR broke the techpreview "[sig-api-machinery] API data in etcd should be stored at the correct location and version for all resources [Serial] [Suite:openshift/conformance/serial]" test which is now failing on nightly payloads.

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run techpreview jobs on the unrevert:

/payload-job periodic-ci-openshift-release-master-ci-4.14-e2e-gcp-sdn-techpreview-serial

CC: @bertinatto, @benluddy

@stbenjam
Revert "Merge pull request openshift#1538 from bertinatto/runtime-con…
a0ae1f0 
…fig-dra"

This reverts commit bfeeda4, reversing
changes made to 7864ef2.
@stbenjam
Revert "Merge pull request openshift#1536 from benluddy/runtime-config"
04846d9 
This reverts commit 7864ef2, reversing
changes made to 7d5e2e0.
@stbenjam stbenjam mentioned this pull request Aug 22, 2023
Closed
@stbenjam stbenjam changed the title Reverts Reverts DynamicResourceAllocation enablement on techpreview Aug 22, 2023
@stbenjam
Copy link
Member Author

/label approved
/label jira/valid-bug
/skip
/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-gcp-operator
/override ci/prow/k8s-e2e-gcp
/override ci/prow/e2e-aws-ovn

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Aug 22, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 22, 2023

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-ovn, ci/prow/e2e-aws-ovn-serial, ci/prow/e2e-aws-ovn-upgrade, ci/prow/e2e-gcp-operator, ci/prow/k8s-e2e-gcp

In response to this:

/label approved
/label jira/valid-bug
/skip
/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-gcp-operator
/override ci/prow/k8s-e2e-gcp
/override ci/prow/e2e-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@benluddy
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2023
@stbenjam
Copy link
Member Author

/label approved

@benluddy
Copy link
Contributor

/hold

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 22, 2023
@benluddy
Copy link
Contributor

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 22, 2023
@benluddy
Copy link
Contributor

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 22, 2023
@deads2k deads2k merged commit 6c5cc50 into openshift:master Aug 22, 2023
9 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benluddy benluddy Awaiting requested review from benluddy

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

Assignees

@benluddy benluddy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stbenjam @benluddy @deads2k