Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-15504: manifest: remove kube-apiserver PrometheusRule #1543

Merged
merged 1 commit into from Sep 18, 2023

Conversation

dgrisonnet
Copy link
Member

The kube-apiserver PrometheusRule was marked to be deleted by CVO in 4.13, so it is now safe to remove the manifest in 4.14.

The kube-apiserver PrometheusRule was marked to be deleted by CVO in
4.13, so it is now safe to remove the manifest in 4.14.

Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 5, 2023
@openshift-ci-robot
Copy link

@dgrisonnet: This pull request references Jira Issue OCPBUGS-15504, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The kube-apiserver PrometheusRule was marked to be deleted by CVO in 4.13, so it is now safe to remove the manifest in 4.14.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgrisonnet
Copy link
Member Author

/assign @vrutkovs

@openshift-ci openshift-ci bot requested a review from wangke19 September 5, 2023 15:34
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2023
@vrutkovs
Copy link
Member

vrutkovs commented Sep 5, 2023

/payload-job periodic-ci-openshift-release-master-ci-4.14-upgrade-from-stable-4.13-e2e-aws-ovn-upgrade
/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 5, 2023

@vrutkovs: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-release-master-ci-4.14-upgrade-from-stable-4.13-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c4eaf650-4c0e-11ee-8480-16212b0e39cd-0

Copy link
Member

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wangke19
Copy link

wangke19 commented Sep 6, 2023

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 6, 2023
@wangke19
Copy link

wangke19 commented Sep 6, 2023

/test required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 6, 2023

@wangke19: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-serial
  • /test e2e-aws-ovn-upgrade
  • /test e2e-gcp-operator
  • /test images
  • /test k8s-e2e-gcp
  • /test unit
  • /test verify
  • /test verify-deps

The following commands are available to trigger optional jobs:

  • /test e2e-aws-operator-disruptive-single-node
  • /test e2e-aws-ovn-single-node
  • /test e2e-azure-ovn
  • /test e2e-gcp-operator-encryption-aescbc
  • /test e2e-gcp-operator-encryption-aesgcm
  • /test e2e-gcp-operator-encryption-perf-aescbc
  • /test e2e-gcp-operator-encryption-perf-aesgcm
  • /test e2e-gcp-operator-encryption-perf-single-node
  • /test e2e-gcp-operator-encryption-rotation-aescbc
  • /test e2e-gcp-operator-encryption-rotation-aesgcm
  • /test e2e-gcp-operator-encryption-rotation-single-node
  • /test e2e-gcp-operator-encryption-single-node
  • /test e2e-gcp-operator-single-node
  • /test e2e-metal-ovn-ha-cert-rotation-shutdown-180d
  • /test e2e-metal-ovn-ha-cert-rotation-shutdown-360d
  • /test e2e-metal-ovn-ha-cert-rotation-shutdown-90d
  • /test e2e-metal-ovn-ha-cert-rotation-suspend-180d
  • /test e2e-metal-ovn-ha-cert-rotation-suspend-360d
  • /test e2e-metal-ovn-ha-cert-rotation-suspend-90d
  • /test e2e-metal-ovn-sno-cert-rotation-shutdown-180d
  • /test e2e-metal-ovn-sno-cert-rotation-shutdown-360d
  • /test e2e-metal-ovn-sno-cert-rotation-shutdown-90d
  • /test e2e-metal-ovn-sno-cert-rotation-suspend-180d
  • /test e2e-metal-ovn-sno-cert-rotation-suspend-360d
  • /test e2e-metal-ovn-sno-cert-rotation-suspend-90d
  • /test e2e-metal-single-node-live-iso
  • /test k8s-e2e-gcp-serial

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-aws-operator-disruptive-single-node
  • pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-aws-ovn
  • pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-aws-ovn-serial
  • pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-aws-ovn-single-node
  • pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-aws-ovn-upgrade
  • pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-gcp-operator
  • pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-gcp-operator-single-node
  • pull-ci-openshift-cluster-kube-apiserver-operator-master-e2e-metal-single-node-live-iso
  • pull-ci-openshift-cluster-kube-apiserver-operator-master-images
  • pull-ci-openshift-cluster-kube-apiserver-operator-master-k8s-e2e-gcp
  • pull-ci-openshift-cluster-kube-apiserver-operator-master-k8s-e2e-gcp-serial
  • pull-ci-openshift-cluster-kube-apiserver-operator-master-unit
  • pull-ci-openshift-cluster-kube-apiserver-operator-master-verify
  • pull-ci-openshift-cluster-kube-apiserver-operator-master-verify-deps

In response to this:

/test required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wangke19
Copy link

wangke19 commented Sep 6, 2023

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 6, 2023

@dgrisonnet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 3faf3f3 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-metal-single-node-live-iso 3faf3f3 link false /test e2e-metal-single-node-live-iso
ci/prow/e2e-aws-operator-disruptive-single-node 3faf3f3 link false /test e2e-aws-operator-disruptive-single-node
ci/prow/e2e-gcp-operator-single-node 3faf3f3 link false /test e2e-gcp-operator-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

@openshift-ci-robot
Copy link

@openshift-bot: This pull request references Jira Issue OCPBUGS-15504, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

In response to this:

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 9dca2dc into openshift:master Sep 18, 2023
11 of 15 checks passed
@openshift-ci-robot
Copy link

@dgrisonnet: Jira Issue OCPBUGS-15504: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-15504 has been moved to the MODIFIED state.

In response to this:

The kube-apiserver PrometheusRule was marked to be deleted by CVO in 4.13, so it is now safe to remove the manifest in 4.14.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants