Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-18939: manifest: drop slo latency metrics in favor of sli #1546

Merged
merged 2 commits into from Jan 17, 2024

Conversation

dgrisonnet
Copy link
Member

The apiserver_request_sli_duration_seconds metric was introduced as a
replacement of apiserver_request_slo_duration_seconds which is
deprecated in Kubernetes 1.27. This is just a renaming so besides
finding and replacing the name of the metrics no other action is
necessary.

To also avoid storing duplicated data in Prometheus, we need to drop
the apiserver_request_slo_duration_seconds at the ServiceMonitor level.

The apiserver_request_sli_duration_seconds metric was introduced as a
replacement of apiserver_request_slo_duration_seconds which is
deprecated in Kubernetes 1.27. This is just a renaming so besides
finding and replacing the name of the metrics no other action is
necessary.

Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 13, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 13, 2023

@dgrisonnet: This pull request references API-1523 which is a valid jira issue.

In response to this:

The apiserver_request_sli_duration_seconds metric was introduced as a
replacement of apiserver_request_slo_duration_seconds which is
deprecated in Kubernetes 1.27. This is just a renaming so besides
finding and replacing the name of the metrics no other action is
necessary.

To also avoid storing duplicated data in Prometheus, we need to drop
the apiserver_request_slo_duration_seconds at the ServiceMonitor level.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2023
@dgrisonnet dgrisonnet changed the title API-1523: manifest: drop sli latency metrics in favor of slo API-1523: manifest: drop slo latency metrics in favor of sli Sep 13, 2023
@dgrisonnet dgrisonnet changed the title API-1523: manifest: drop slo latency metrics in favor of sli OCPBUGS-18939: manifest: drop slo latency metrics in favor of sli Sep 13, 2023
@openshift-ci-robot
Copy link

@dgrisonnet: This pull request references Jira Issue OCPBUGS-18939, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The apiserver_request_sli_duration_seconds metric was introduced as a
replacement of apiserver_request_slo_duration_seconds which is
deprecated in Kubernetes 1.27. This is just a renaming so besides
finding and replacing the name of the metrics no other action is
necessary.

To also avoid storing duplicated data in Prometheus, we need to drop
the apiserver_request_slo_duration_seconds at the ServiceMonitor level.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Sep 13, 2023
@wangke19
Copy link

wangke19 commented Nov 9, 2023

@dgrisonnet Please review the test results https://issues.redhat.com/browse/OCPBUGS-18939?focusedId=23444263&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-23444263 after I pre-mrege verified the bug. Please confirm whether the result is as expected.

@dgrisonnet
Copy link
Member Author

/retest-required

@wangke19
Copy link

wangke19 commented Jan 5, 2024

pre-merge verified the associated bug, got the result is as expected. Detail see https://issues.redhat.com/browse/OCPBUGS-18939?focusedId=23729744&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-23729744.
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 5, 2024
@wangke19
Copy link

wangke19 commented Jan 5, 2024

/retest-required

@openshift-ci-robot
Copy link

@dgrisonnet: This pull request references Jira Issue OCPBUGS-18939, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

In response to this:

The apiserver_request_sli_duration_seconds metric was introduced as a
replacement of apiserver_request_slo_duration_seconds which is
deprecated in Kubernetes 1.27. This is just a renaming so besides
finding and replacing the name of the metrics no other action is
necessary.

To also avoid storing duplicated data in Prometheus, we need to drop
the apiserver_request_slo_duration_seconds at the ServiceMonitor level.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wangke19
Copy link

wangke19 commented Jan 5, 2024

/retest

1 similar comment
@wangke19
Copy link

/retest

@wangke19
Copy link

/test e2e-gcp-operator-single-node

@wangke19
Copy link

/test e2e-aws-operator-disruptive-single-node

Copy link
Contributor

openshift-ci bot commented Jan 16, 2024

@dgrisonnet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-operator-disruptive-single-node 9612e26 link false /test e2e-aws-operator-disruptive-single-node
ci/prow/e2e-gcp-operator-single-node 9612e26 link false /test e2e-gcp-operator-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wangke19
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2024
Copy link
Contributor

openshift-ci bot commented Jan 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, wangke19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 758ac1c and 2 for PR HEAD 9612e26 in total

@openshift-merge-bot openshift-merge-bot bot merged commit f351eb4 into openshift:master Jan 17, 2024
13 of 15 checks passed
@openshift-ci-robot
Copy link

@dgrisonnet: Jira Issue OCPBUGS-18939: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-18939 has not been moved to the MODIFIED state.

In response to this:

The apiserver_request_sli_duration_seconds metric was introduced as a
replacement of apiserver_request_slo_duration_seconds which is
deprecated in Kubernetes 1.27. This is just a renaming so besides
finding and replacing the name of the metrics no other action is
necessary.

To also avoid storing duplicated data in Prometheus, we need to drop
the apiserver_request_slo_duration_seconds at the ServiceMonitor level.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants