New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-18939: manifest: drop slo latency metrics in favor of sli #1546
Conversation
The apiserver_request_sli_duration_seconds metric was introduced as a replacement of apiserver_request_slo_duration_seconds which is deprecated in Kubernetes 1.27. This is just a renaming so besides finding and replacing the name of the metrics no other action is necessary. Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
@dgrisonnet: This pull request references API-1523 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
599ee58
to
9612e26
Compare
@dgrisonnet: This pull request references Jira Issue OCPBUGS-18939, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@dgrisonnet Please review the test results https://issues.redhat.com/browse/OCPBUGS-18939?focusedId=23444263&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-23444263 after I pre-mrege verified the bug. Please confirm whether the result is as expected. |
/retest-required |
pre-merge verified the associated bug, got the result is as expected. Detail see https://issues.redhat.com/browse/OCPBUGS-18939?focusedId=23729744&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-23729744. |
/retest-required |
@dgrisonnet: This pull request references Jira Issue OCPBUGS-18939, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest |
1 similar comment
/retest |
/test e2e-gcp-operator-single-node |
/test e2e-aws-operator-disruptive-single-node |
@dgrisonnet: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrisonnet, wangke19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f351eb4
into
openshift:master
@dgrisonnet: Jira Issue OCPBUGS-18939: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-18939 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
The apiserver_request_sli_duration_seconds metric was introduced as a
replacement of apiserver_request_slo_duration_seconds which is
deprecated in Kubernetes 1.27. This is just a renaming so besides
finding and replacing the name of the metrics no other action is
necessary.
To also avoid storing duplicated data in Prometheus, we need to drop
the apiserver_request_slo_duration_seconds at the ServiceMonitor level.